[ios] Remove AR module #8442
Merged
[ios] Remove AR module #8442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
tsapeta
approved these changes
May 22, 2020
esamelson
reviewed
May 23, 2020
There was a problem hiding this comment.
thanks @sjchmiela ! Apologies this wasn't clear before, but we do actually want to remove the AR module from all versioned SDKs as well -- the reason for doing this in the first place is to remove the ARKit dependency entirely from the App Store Expo client. (It's fine if we end up doing the removal from versioned SDKs in a separate PR.)
sjchmiela
force-pushed
the
@sjchmiela/remove-ar
branch
from
2ad9098
to
f0fd846
Compare
tsapeta
approved these changes
May 25, 2020
esamelson
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Completes two more checks from #8371.
How
ARKitdirectory fromOptionaldirectory from inside Exponent project.ARmodule export fromexpoin favor of a simple throwing export inremoved.ts.Test Plan
expopackage built. Expo client for iOS built too.