[android] Bump compileSdkVersion to 29 #8450

tsapeta · 2020-05-22T23:13:00Z

Why

After #8431 the client doesn't build because PackageManager.FEATURE_FACE and PackageManager.FEATURE_IRIS were added in Android SDK29, but we're still targeting SDK28.

How

Updated to 29 (Android 10) all occurrences of targetSdkVersion and compileSdkVersion being set to 28 (Android 9).

Test Plan

Tested the client on Android emulator with Android 9 – seems to work as expected. Same for Android 10, however I don't have any Android 10 device around so I haven't been able to test it on real device 😞

ExpoBot · 2020-05-22T23:33:30Z

	Fails
🚫	📋 Missing Changelog 🛠 Add missing entires to: `packages/expo-ads-admob/CHANGELOG.md` `packages/expo-ads-facebook/CHANGELOG.md` `packages/expo-analytics-amplitude/CHANGELOG.md` `packages/expo-analytics-segment/CHANGELOG.md` `packages/expo-app-auth/CHANGELOG.md` `packages/expo-application/CHANGELOG.md` `packages/expo-av/CHANGELOG.md` `packages/expo-background-fetch/CHANGELOG.md` `packages/expo-barcode-scanner/CHANGELOG.md` `packages/expo-battery/CHANGELOG.md` `packages/expo-branch/CHANGELOG.md` `packages/expo-brightness/CHANGELOG.md` `packages/expo-calendar/CHANGELOG.md` `packages/expo-camera/CHANGELOG.md` `packages/expo-cellular/CHANGELOG.md` `packages/expo-constants/CHANGELOG.md` `packages/expo-contacts/CHANGELOG.md` `packages/expo-crypto/CHANGELOG.md` `packages/expo-device/CHANGELOG.md` `packages/expo-document-picker/CHANGELOG.md` `packages/expo-error-recovery/CHANGELOG.md` `packages/expo-face-detector/CHANGELOG.md` `packages/expo-facebook/CHANGELOG.md` `packages/expo-file-system/CHANGELOG.md` `packages/expo-firebase-analytics/CHANGELOG.md` `packages/expo-firebase-core/CHANGELOG.md` `packages/expo-font/CHANGELOG.md` `packages/expo-gl/CHANGELOG.md` `packages/expo-google-sign-in/CHANGELOG.md` `packages/expo-haptics/CHANGELOG.md` `packages/expo-image-loader/CHANGELOG.md` `packages/expo-image-manipulator/CHANGELOG.md` `packages/expo-image-picker/CHANGELOG.md` `packages/expo-intent-launcher/CHANGELOG.md` `packages/expo-keep-awake/CHANGELOG.md` `packages/expo-linear-gradient/CHANGELOG.md` `packages/expo-local-authentication/CHANGELOG.md` `packages/expo-localization/CHANGELOG.md` `packages/expo-location/CHANGELOG.md` `packages/expo-mail-composer/CHANGELOG.md` `packages/expo-media-library/CHANGELOG.md` `packages/expo-network/CHANGELOG.md` `packages/expo-notifications/CHANGELOG.md` `packages/expo-payments-stripe/CHANGELOG.md` `packages/expo-permissions/CHANGELOG.md` `packages/expo-print/CHANGELOG.md` `packages/expo-random/CHANGELOG.md` `packages/expo-screen-orientation/CHANGELOG.md` `packages/expo-secure-store/CHANGELOG.md` `packages/expo-sensors/CHANGELOG.md` `packages/expo-sharing/CHANGELOG.md` `packages/expo-sms/CHANGELOG.md` `packages/expo-speech/CHANGELOG.md` `packages/expo-sqlite/CHANGELOG.md` `packages/expo-task-manager/CHANGELOG.md` `packages/expo-video-thumbnails/CHANGELOG.md` `packages/expo-web-browser/CHANGELOG.md` `packages/unimodules-app-loader/CHANGELOG.md` `packages/unimodules-barcode-scanner-interface/CHANGELOG.md` `packages/unimodules-camera-interface/CHANGELOG.md` `packages/unimodules-constants-interface/CHANGELOG.md` `packages/unimodules-face-detector-interface/CHANGELOG.md` `packages/unimodules-file-system-interface/CHANGELOG.md` `packages/unimodules-font-interface/CHANGELOG.md` `packages/unimodules-image-loader-interface/CHANGELOG.md` `packages/unimodules-permissions-interface/CHANGELOG.md` `packages/unimodules-sensors-interface/CHANGELOG.md` `packages/unimodules-task-manager-interface/CHANGELOG.md`

🛠 Suggested fixes:

📋 Missing changelog

Apply suggested changes:

diff --git a/packages/expo-ads-admob/CHANGELOG.md b/packages/expo-ads-admob/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-ads-admob/CHANGELOG.md
+++ b/packages/expo-ads-admob/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-ads-facebook/CHANGELOG.md b/packages/expo-ads-facebook/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-ads-facebook/CHANGELOG.md
+++ b/packages/expo-ads-facebook/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-analytics-amplitude/CHANGELOG.md b/packages/expo-analytics-amplitude/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-analytics-amplitude/CHANGELOG.md
+++ b/packages/expo-analytics-amplitude/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-analytics-segment/CHANGELOG.md b/packages/expo-analytics-segment/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-analytics-segment/CHANGELOG.md
+++ b/packages/expo-analytics-segment/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-app-auth/CHANGELOG.md b/packages/expo-app-auth/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-app-auth/CHANGELOG.md
+++ b/packages/expo-app-auth/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-application/CHANGELOG.md b/packages/expo-application/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-application/CHANGELOG.md
+++ b/packages/expo-application/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-av/CHANGELOG.md b/packages/expo-av/CHANGELOG.md
index 376bc9eabd..083f3b6bbb 100644
--- a/packages/expo-av/CHANGELOG.md
+++ b/packages/expo-av/CHANGELOG.md
@@ -12,3 +12,4 @@
 - Fixed multiplied callbacks in `expo-av` after replaying ([#7193](https://github.com/expo/expo/pull/7193) by [@mczernek](https://github.com/mczernek))
 - Fixed `Plaback.loadAsync()` return type. ([#7559](https://github.com/expo/expo/pull/7559) by [@awinograd](https://github.com/awinograd))
 - Fixed the adaptive streaming for exoplayer on android. ([#8380](https://github.com/expo/expo/pull/8363) by [@watchinharrison](https://github.com/watchinharrison))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-background-fetch/CHANGELOG.md b/packages/expo-background-fetch/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-background-fetch/CHANGELOG.md
+++ b/packages/expo-background-fetch/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-barcode-scanner/CHANGELOG.md b/packages/expo-barcode-scanner/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-barcode-scanner/CHANGELOG.md
+++ b/packages/expo-barcode-scanner/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-battery/CHANGELOG.md b/packages/expo-battery/CHANGELOG.md
index 0ef0429311..a0d8873b27 100644
--- a/packages/expo-battery/CHANGELOG.md
+++ b/packages/expo-battery/CHANGELOG.md
@@ -9,3 +9,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-branch/CHANGELOG.md b/packages/expo-branch/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-branch/CHANGELOG.md
+++ b/packages/expo-branch/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-brightness/CHANGELOG.md b/packages/expo-brightness/CHANGELOG.md
index 970004085d..c2e1a8e7e7 100644
--- a/packages/expo-brightness/CHANGELOG.md
+++ b/packages/expo-brightness/CHANGELOG.md
@@ -9,3 +9,4 @@
 ### 🐛 Bug fixes
 
 - Fixed `Brightness.requestPermissionsAsync` throwing `permission cannot be null or empty` error on Android. ([#7276](https://github.com/expo/expo/pull/7276) by [@lukmccall](https://github.com/lukmccall))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-calendar/CHANGELOG.md b/packages/expo-calendar/CHANGELOG.md
index 9e297b41b2..a80ea69418 100644
--- a/packages/expo-calendar/CHANGELOG.md
+++ b/packages/expo-calendar/CHANGELOG.md
@@ -10,3 +10,4 @@
 
 - Fixed `Calendar.getCalendarsAsync` requiring not needed permissions on iOS. ([#7928](https://github.com/expo/expo/pull/7928) by [@lukmccall](https://github.com/lukmccall))
 - Fix `recurrence rule` and `event` parsing. ([#7527](https://github.com/expo/expo/pull/7527) by [@lukmccall](https://github.com/lukmccall))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-camera/CHANGELOG.md b/packages/expo-camera/CHANGELOG.md
index c77b52ccf6..3c12872074 100644
--- a/packages/expo-camera/CHANGELOG.md
+++ b/packages/expo-camera/CHANGELOG.md
@@ -9,3 +9,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-cellular/CHANGELOG.md b/packages/expo-cellular/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-cellular/CHANGELOG.md
+++ b/packages/expo-cellular/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-constants/CHANGELOG.md b/packages/expo-constants/CHANGELOG.md
index 28337a838c..05b597e2f0 100644
--- a/packages/expo-constants/CHANGELOG.md
+++ b/packages/expo-constants/CHANGELOG.md
@@ -9,3 +9,4 @@
 ### 🐛 Bug fixes
 
 - Fixed `uuid`'s deprecation of deep requiring ([#8114](https://github.com/expo/expo/pull/8114) by [@actuallymentor](https://github.com/actuallymentor))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-contacts/CHANGELOG.md b/packages/expo-contacts/CHANGELOG.md
index 6e882cb2ba..023ff6bcc3 100644
--- a/packages/expo-contacts/CHANGELOG.md
+++ b/packages/expo-contacts/CHANGELOG.md
@@ -9,3 +9,4 @@
 ### 🐛 Bug fixes
 
 - Fix `Contacts.presentFormAsync` pre-filling. ([#7285](https://github.com/expo/expo/pull/7285) by [@abdelilah](https://github.com/abdelilah) & [@lukmccall](https://github.com/lukmccall))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-crypto/CHANGELOG.md b/packages/expo-crypto/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-crypto/CHANGELOG.md
+++ b/packages/expo-crypto/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-device/CHANGELOG.md b/packages/expo-device/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-device/CHANGELOG.md
+++ b/packages/expo-device/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-document-picker/CHANGELOG.md b/packages/expo-document-picker/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-document-picker/CHANGELOG.md
+++ b/packages/expo-document-picker/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-error-recovery/CHANGELOG.md b/packages/expo-error-recovery/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-error-recovery/CHANGELOG.md
+++ b/packages/expo-error-recovery/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-face-detector/CHANGELOG.md b/packages/expo-face-detector/CHANGELOG.md
index b181b6ac18..1e86337bbd 100644
--- a/packages/expo-face-detector/CHANGELOG.md
+++ b/packages/expo-face-detector/CHANGELOG.md
@@ -9,3 +9,5 @@
 - Added support for overriding the iOS Firebase SDK version in the bare workflow. ([#7141](https://github.com/expo/expo/pull/7141) by [@IjzerenHein](https://github.com/IjzerenHein))
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-facebook/CHANGELOG.md b/packages/expo-facebook/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-facebook/CHANGELOG.md
+++ b/packages/expo-facebook/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-file-system/CHANGELOG.md b/packages/expo-file-system/CHANGELOG.md
index 41e81a2400..da2145eb1a 100644
--- a/packages/expo-file-system/CHANGELOG.md
+++ b/packages/expo-file-system/CHANGELOG.md
@@ -14,3 +14,5 @@
 - Add ability to read Android `raw` and `drawable` resources in `FileSystem.getInfoAsync`, `FileSystem.readAsStringAsync`, and `FileSystem.copyAsync`. ([#8104](https://github.com/expo/expo/pull/8104) by [@esamelson](https://github.com/esamelson))
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-firebase-analytics/CHANGELOG.md b/packages/expo-firebase-analytics/CHANGELOG.md
index e16992f083..0bd36f23c9 100644
--- a/packages/expo-firebase-analytics/CHANGELOG.md
+++ b/packages/expo-firebase-analytics/CHANGELOG.md
@@ -14,4 +14,4 @@
 - Fix `setAnalyticsCollectionEnabled` throwing an error.
 - Fixes & improvements to the pure JS analytics client. ([#7796](https://github.com/expo/expo/pull/7796) by [@IjzerenHein](https://github.com/IjzerenHein))
 - Fixed logEvent in `expo-firebase-analytics` for Android. logEvent's optional properties parameter was causing a NPE on Android when not provided. ([#7897](https://github.com/expo/expo/pull/7897) by [@thorbenprimke](https://github.com/thorbenprimke))
-
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-firebase-core/CHANGELOG.md b/packages/expo-firebase-core/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-firebase-core/CHANGELOG.md
+++ b/packages/expo-firebase-core/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-font/CHANGELOG.md b/packages/expo-font/CHANGELOG.md
index 315d88f8cc..dae3f732f7 100644
--- a/packages/expo-font/CHANGELOG.md
+++ b/packages/expo-font/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))
+
 ## 8.1.1 - 4/07/2020
 
 ### 🐛 Bug fixes

diff --git a/packages/expo-gl/CHANGELOG.md b/packages/expo-gl/CHANGELOG.md
index ec77c1295a..1dda53ef1b 100644
--- a/packages/expo-gl/CHANGELOG.md
+++ b/packages/expo-gl/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))
+
 ## 8.2.0
 
 ### 🎉 New features

diff --git a/packages/expo-google-sign-in/CHANGELOG.md b/packages/expo-google-sign-in/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-google-sign-in/CHANGELOG.md
+++ b/packages/expo-google-sign-in/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-haptics/CHANGELOG.md b/packages/expo-haptics/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-haptics/CHANGELOG.md
+++ b/packages/expo-haptics/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-image-loader/CHANGELOG.md b/packages/expo-image-loader/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-image-loader/CHANGELOG.md
+++ b/packages/expo-image-loader/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-image-manipulator/CHANGELOG.md b/packages/expo-image-manipulator/CHANGELOG.md
index c77b52ccf6..3c12872074 100644
--- a/packages/expo-image-manipulator/CHANGELOG.md
+++ b/packages/expo-image-manipulator/CHANGELOG.md
@@ -9,3 +9,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-image-picker/CHANGELOG.md b/packages/expo-image-picker/CHANGELOG.md
index bda4c5ef93..2a77048920 100644
--- a/packages/expo-image-picker/CHANGELOG.md
+++ b/packages/expo-image-picker/CHANGELOG.md
@@ -11,3 +11,4 @@
 ### 🐛 Bug fixes
 
 - Fixed exception when calling `ImagePicker.getCameraPermissionsAsync` on Web. ([#7498](https://github.com/expo/expo/pull/7498) by [@IjzerenHein](https://github.com/IjzerenHein))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-intent-launcher/CHANGELOG.md b/packages/expo-intent-launcher/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-intent-launcher/CHANGELOG.md
+++ b/packages/expo-intent-launcher/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-keep-awake/CHANGELOG.md b/packages/expo-keep-awake/CHANGELOG.md
index 20d5d3d1b3..0cc2418a11 100644
--- a/packages/expo-keep-awake/CHANGELOG.md
+++ b/packages/expo-keep-awake/CHANGELOG.md
@@ -9,3 +9,4 @@
 ### 🐛 Bug fixes
 
 - Fixed `KeepAwake.activateKeepAwake` not working with multiple tags on Android. ([#7197](https://github.com/expo/expo/pull/7197) by [@lukmccall](https://github.com/lukmccall))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-linear-gradient/CHANGELOG.md b/packages/expo-linear-gradient/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-linear-gradient/CHANGELOG.md
+++ b/packages/expo-linear-gradient/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-local-authentication/CHANGELOG.md b/packages/expo-local-authentication/CHANGELOG.md
index 57993dca47..68a385f6b3 100644
--- a/packages/expo-local-authentication/CHANGELOG.md
+++ b/packages/expo-local-authentication/CHANGELOG.md
@@ -12,3 +12,4 @@
 ### 🐛 Bug fixes
 
 - Added estimate of supported authentication types for Android. ([#8431](https://github.com/expo/expo/pull/8431) by [@bycedric](https://github.com/bycedric))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-localization/CHANGELOG.md b/packages/expo-localization/CHANGELOG.md
index 40f8edc400..2a04e4b1ba 100644
--- a/packages/expo-localization/CHANGELOG.md
+++ b/packages/expo-localization/CHANGELOG.md
@@ -9,3 +9,4 @@
 ### 🐛 Bug fixes
 
 - Fixed `Localization.locale` throwing an exception on the iOS simulator. ([#8193](https://github.com/expo/expo/pull/8193) by [@lukmccall](https://github.com/lukmccall))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-location/CHANGELOG.md b/packages/expo-location/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-location/CHANGELOG.md
+++ b/packages/expo-location/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-mail-composer/CHANGELOG.md b/packages/expo-mail-composer/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-mail-composer/CHANGELOG.md
+++ b/packages/expo-mail-composer/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-media-library/CHANGELOG.md b/packages/expo-media-library/CHANGELOG.md
index 1d5f1656cf..323d673622 100644
--- a/packages/expo-media-library/CHANGELOG.md
+++ b/packages/expo-media-library/CHANGELOG.md
@@ -11,3 +11,4 @@
 - Added missing image loader for `MediaLibrary` in bare workflow. ([#8304](https://github.com/expo/expo/pull/8304) by [@tsapeta](https://github.com/tsapeta))
 - Fixed `MediaLibrary` not compiling with the `use_frameworks!` option in the bare React Native application. ([#7861](https://github.com/expo/expo/pull/7861) by [@Ashoat](https://github.com/Ashoat))
 - Flip dimensions based on media rotation data on Android to match `<Image>` and `<Video>` as well as iOS behavior. ([#7980](https://github.com/expo/expo/pull/7980) by [@Ashoat](https://github.com/Ashoat))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-network/CHANGELOG.md b/packages/expo-network/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-network/CHANGELOG.md
+++ b/packages/expo-network/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-notifications/CHANGELOG.md b/packages/expo-notifications/CHANGELOG.md
index 24f090b5f8..28836c5691 100644
--- a/packages/expo-notifications/CHANGELOG.md
+++ b/packages/expo-notifications/CHANGELOG.md
@@ -5,9 +5,7 @@
 ### 🛠 Breaking changes
 
 - > Note that this may or may not be a breaking change for you — if you'd expect the notification to be automatically dismissed when tapped on this is a bug fix and a new feature (fixes inconsistency between platforms as on iOS this is the only supported behavior; adds the ability to customize the behavior on Android). If you'd expect the notification to only be dismissed at your will this is a breaking change and you'll need to add `autoDismiss: false` to your notification content inputs.
-
-  Changed the default notification behavior on Android to be automatically dismissed when clicked. This is customizable with the `autoDismiss` parameter of `NotificationContentInput`. ([#8241](https://github.com/expo/expo/pull/8241) by [@thorbenprimke](https://github.com/thorbenprimke))
-  
+Changed the default notification behavior on Android to be automatically dismissed when clicked. This is customizable with the `autoDismiss` parameter of `NotificationContentInput`. ([#8241](https://github.com/expo/expo/pull/8241) by [@thorbenprimke](https://github.com/thorbenprimke))
 
 ### 🎉 New features
 
@@ -19,6 +17,7 @@
 - Added a macro check for `UNLocationNotificationTrigger` to make this module compatible with Mac Catalyst ([#8171](https://github.com/expo/expo/pull/8171) by [@robertying](https://github.com/robertying))
 - Fixed notification content text being truncated without the ability to expand the notification by adding [`BigTextStyle`](https://developer.android.com/reference/android/app/Notification.BigTextStyle) to all Android notifications, which allows them to be expanded and their content text fully viewed ([#8140](https://github.com/expo/expo/pull/8140) by [@thorbenprimke](https://github.com/thorbenprimke))
 - Added a check for trigger input that throws an error if user misuses the `seconds` property ([#8261](https://github.com/expo/expo/pull/8261) by [@sjchmiela](https://github.com/sjchmiela))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))
 
 ## [0.1.7] - 2020-05-05
 

diff --git a/packages/expo-payments-stripe/CHANGELOG.md b/packages/expo-payments-stripe/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-payments-stripe/CHANGELOG.md
+++ b/packages/expo-payments-stripe/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-permissions/CHANGELOG.md b/packages/expo-permissions/CHANGELOG.md
index 47643e2977..74217a91c5 100644
--- a/packages/expo-permissions/CHANGELOG.md
+++ b/packages/expo-permissions/CHANGELOG.md
@@ -11,3 +11,4 @@
 - Fix permissions in the headless mode. ([#7962](https://github.com/expo/expo/pull/7962) by [@lukmccall](https://github.com/lukmccall))
 - Fixed `permission cannot be null or empty` error when asking for `WRITE_SETTINGS` permission on Android. ([#7276](https://github.com/expo/expo/pull/7276) by [@lukmccall](https://github.com/lukmccall))
 - Fixed a rare undetermined behavior that may have been a result of misuse of `dispatch_once_t` on iOS ([#7576](https://github.com/expo/expo/pull/7576) by [@sjchmiela](https://github.com/sjchmiela))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-print/CHANGELOG.md b/packages/expo-print/CHANGELOG.md
index c77b52ccf6..3c12872074 100644
--- a/packages/expo-print/CHANGELOG.md
+++ b/packages/expo-print/CHANGELOG.md
@@ -9,3 +9,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-random/CHANGELOG.md b/packages/expo-random/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-random/CHANGELOG.md
+++ b/packages/expo-random/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-screen-orientation/CHANGELOG.md b/packages/expo-screen-orientation/CHANGELOG.md
index 624e055af1..caad8ef304 100644
--- a/packages/expo-screen-orientation/CHANGELOG.md
+++ b/packages/expo-screen-orientation/CHANGELOG.md
@@ -10,3 +10,4 @@
 
 - Fixed `ScreenOrientation.addOrientationChangeListener` payload to match docs. ([#7774](https://github.com/expo/expo/pull/7774) by [@awinograd](https://github.com/awinograd))
 - Fixed `ScreenOrientation.lockAsync` to properly convert to web platform equivalent of chosen lock. ([#7774](https://github.com/expo/expo/pull/7774) by [@awinograd](https://github.com/awinograd))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-secure-store/CHANGELOG.md b/packages/expo-secure-store/CHANGELOG.md
index c77b52ccf6..3c12872074 100644
--- a/packages/expo-secure-store/CHANGELOG.md
+++ b/packages/expo-secure-store/CHANGELOG.md
@@ -9,3 +9,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-sensors/CHANGELOG.md b/packages/expo-sensors/CHANGELOG.md
index 8d9a7a9ce3..c88ac5e0d0 100644
--- a/packages/expo-sensors/CHANGELOG.md
+++ b/packages/expo-sensors/CHANGELOG.md
@@ -14,3 +14,4 @@
 ### 🐛 Bug fixes
 
 - All sensors use more precise gravity `9.80665` instead of `9.8`. ([#7876](https://github.com/expo/expo/pull/7876) by [@evanbacon](https://github.com/evanbacon))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-sharing/CHANGELOG.md b/packages/expo-sharing/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-sharing/CHANGELOG.md
+++ b/packages/expo-sharing/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-sms/CHANGELOG.md b/packages/expo-sms/CHANGELOG.md
index a1e4ba1d34..a0409979c1 100644
--- a/packages/expo-sms/CHANGELOG.md
+++ b/packages/expo-sms/CHANGELOG.md
@@ -9,3 +9,5 @@
 - Add `attachments` as an optional parameter to `sendSMSAsync`. It can be used to provide an attachment along with the recipients and message arguments. ([#7967](https://github.com/expo/expo/pull/7967) by [@thorbenprimke](https://github.com/thorbenprimke))
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-speech/CHANGELOG.md b/packages/expo-speech/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-speech/CHANGELOG.md
+++ b/packages/expo-speech/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-sqlite/CHANGELOG.md b/packages/expo-sqlite/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-sqlite/CHANGELOG.md
+++ b/packages/expo-sqlite/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-task-manager/CHANGELOG.md b/packages/expo-task-manager/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-task-manager/CHANGELOG.md
+++ b/packages/expo-task-manager/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-video-thumbnails/CHANGELOG.md b/packages/expo-video-thumbnails/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/expo-video-thumbnails/CHANGELOG.md
+++ b/packages/expo-video-thumbnails/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/expo-web-browser/CHANGELOG.md b/packages/expo-web-browser/CHANGELOG.md
index ab076e05ee..4956b68fa3 100644
--- a/packages/expo-web-browser/CHANGELOG.md
+++ b/packages/expo-web-browser/CHANGELOG.md
@@ -11,3 +11,4 @@
 ### 🐛 Bug fixes
 
 - Fix `WebBrowser` sending `dismiss` before opening. ([#6743](https://github.com/expo/expo/pull/6743) by [@LucaColonnello](https://github.com/LucaColonnello))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/unimodules-app-loader/CHANGELOG.md b/packages/unimodules-app-loader/CHANGELOG.md
index e23a2d85f6..c061643163 100644
--- a/packages/unimodules-app-loader/CHANGELOG.md
+++ b/packages/unimodules-app-loader/CHANGELOG.md
@@ -9,3 +9,4 @@
 ### 🐛 Bug fixes
 
 - Fixed `appLoaderRegisteredForName` to not only check if a loader class name is in the cache for the provided name but also verifies that the cached and current class name match. When migrating from managed to bare, the class name cache needs to be updated. ([#8292](https://github.com/expo/expo/pull/8292) by [@thorbenprimke](https://github.com/thorbenprimke))
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/unimodules-barcode-scanner-interface/CHANGELOG.md b/packages/unimodules-barcode-scanner-interface/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/unimodules-barcode-scanner-interface/CHANGELOG.md
+++ b/packages/unimodules-barcode-scanner-interface/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/unimodules-camera-interface/CHANGELOG.md b/packages/unimodules-camera-interface/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/unimodules-camera-interface/CHANGELOG.md
+++ b/packages/unimodules-camera-interface/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/unimodules-constants-interface/CHANGELOG.md b/packages/unimodules-constants-interface/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/unimodules-constants-interface/CHANGELOG.md
+++ b/packages/unimodules-constants-interface/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/unimodules-face-detector-interface/CHANGELOG.md b/packages/unimodules-face-detector-interface/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/unimodules-face-detector-interface/CHANGELOG.md
+++ b/packages/unimodules-face-detector-interface/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/unimodules-file-system-interface/CHANGELOG.md b/packages/unimodules-file-system-interface/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/unimodules-file-system-interface/CHANGELOG.md
+++ b/packages/unimodules-file-system-interface/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/unimodules-font-interface/CHANGELOG.md b/packages/unimodules-font-interface/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/unimodules-font-interface/CHANGELOG.md
+++ b/packages/unimodules-font-interface/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/unimodules-image-loader-interface/CHANGELOG.md b/packages/unimodules-image-loader-interface/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/unimodules-image-loader-interface/CHANGELOG.md
+++ b/packages/unimodules-image-loader-interface/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/unimodules-permissions-interface/CHANGELOG.md b/packages/unimodules-permissions-interface/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/unimodules-permissions-interface/CHANGELOG.md
+++ b/packages/unimodules-permissions-interface/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/unimodules-sensors-interface/CHANGELOG.md b/packages/unimodules-sensors-interface/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/unimodules-sensors-interface/CHANGELOG.md
+++ b/packages/unimodules-sensors-interface/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

diff --git a/packages/unimodules-task-manager-interface/CHANGELOG.md b/packages/unimodules-task-manager-interface/CHANGELOG.md
index 6a294c6841..d918d1860a 100644
--- a/packages/unimodules-task-manager-interface/CHANGELOG.md
+++ b/packages/unimodules-task-manager-interface/CHANGELOG.md
@@ -7,3 +7,5 @@
 ### 🎉 New features
 
 ### 🐛 Bug fixes
+
+- Bump compileSdkVersion to 29 ([#8450](https://github.com/expo/expo/pull/8450) by [@tsapeta](https://github.com/tsapeta))

Generated by 🚫 dangerJS against 14e8836

github-actions · 2020-05-24T08:34:57Z

Native Component List for this branch is ready

brentvatne · 2020-05-24T23:31:52Z

android/expoview/build.gradle

@@ -65,7 +65,7 @@ repositories {
 }

 android {
-  compileSdkVersion safeExtGet("compileSdkVersion", 28)
+  compileSdkVersion safeExtGet("compilesdkversion", 29)


was it intentional to change compileSdkVersion to compilesdkversion in a bunch of places in this commit?

Oops, good catch, it wasn't intentional, sorry 😅

sjchmiela · 2020-05-25T07:21:13Z

Have you went through all the changes in https://developer.android.com/about/versions/10/behavior-changes-all and made sure that nothing affects us or if it does, we have changed the code accordingly?

Did you test the app and all the modules on Android 10?

Is it possible to upgrade the targetSdkVersion only in expo-local-authentication?

mczernek · 2020-05-25T07:37:50Z

Have you went through all the changes in https://developer.android.com/about/versions/10/behavior-changes-all and made sure that nothing affects us or if it does, we have changed the code accordingly?

I went through them and do not see anything particulary dangerous. Most concerns are brought by support for foldable screens and hence for multiple resumed activities. We can have some logic that relies on only one activity being resumed, can't we?
Anyway, we won't know before we test it.

Is it possible to upgrade the targetSdkVersion only in expo-local-authentication?

App can have only one targetSdk. AFAIR the one from application module will be used by default. Even if I am wrong about the latter, I am 100% sure app cannot have two different target versions, and it gets unified somehow.

tsapeta · 2020-05-25T09:34:31Z

Thanks for spotting the problem with compileSdkVersion casing and asking about behavior changes in Android 10 - it turned out that we will have to do some changes regarding https://developer.android.com/reference/android/Manifest.permission#ACCESS_BACKGROUND_LOCATION
@mczernek volunteered to take care of this 🙇‍♂️ so it'll be in separate PR. Thus I think this PR is mergeable.

EDIT: I've tested it on Android 10 emulator too, however I haven't been able to test it on real device (I upgraded test plan in the description).

apps/bare-expo/android/build.gradle

android/build.gradle

Co-authored-by: Michał Czernek <czernekmichal@gmail.com>

[android] Bump targetSdkVersion and compileSdkVersion to 29

5cb8450

[bare-expo] Bump targetSdkVersion and compileSdkVersion to 29

b76df22

tsapeta marked this pull request as ready for review May 24, 2020 08:35

tsapeta requested review from bbarthec, brentvatne, EvanBacon, ide, IjzerenHein, lukmccall, mczernek and sjchmiela as code owners May 24, 2020 08:35

tsapeta requested review from esamelson and removed request for brentvatne, mczernek, IjzerenHein, lukmccall, EvanBacon and bbarthec May 24, 2020 08:36

brentvatne reviewed May 24, 2020

View reviewed changes

sjchmiela requested a review from mczernek May 25, 2020 07:21

[android] Fix casing of compileSdkVersion

a559666

tsapeta changed the title ~~[android] Bump targetSdkVersion and compileSdkVersion to 29~~ [android] Bump compileSdkVersion to 29 May 25, 2020

[android] Bump only compileSdkVersion

b5ea43e

tsapeta mentioned this pull request May 25, 2020

Bump targetSdkVersion to Android 10 and adapt to behavior changes #8469

Closed

mczernek suggested changes May 25, 2020

View reviewed changes

apps/bare-expo/android/build.gradle Outdated Show resolved Hide resolved

android/build.gradle Outdated Show resolved Hide resolved

Apply suggestions from code review

14e8836

Co-authored-by: Michał Czernek <czernekmichal@gmail.com>

mczernek approved these changes May 25, 2020

View reviewed changes

tsapeta merged commit 0b32d82 into master May 25, 2020

tsapeta deleted the @tsapeta/update-android-sdk-29 branch May 25, 2020 13:10

tsapeta mentioned this pull request May 25, 2020

[ci] Update Docker image for Android API 29 #8471

Merged

Jamedjo pushed a commit to Jamedjo/expo that referenced this pull request Feb 4, 2021

[android] Bump compileSdkVersion to 29 (expo#8450)

763d424

prakashbask pushed a commit to prakashbask/expo that referenced this pull request Mar 16, 2022

[android] Bump compileSdkVersion to 29 (expo#8450)

3da0dc1

gurs1kh pushed a commit to gurs1kh/expo that referenced this pull request Jan 18, 2024

[android] Bump compileSdkVersion to 29 (expo#8450)

2bea322

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[android] Bump compileSdkVersion to 29 #8450

[android] Bump compileSdkVersion to 29 #8450

tsapeta commented May 22, 2020 •

edited

ExpoBot commented May 22, 2020 •

edited

📋 Missing Changelog

Apply suggested changes:

github-actions bot commented May 24, 2020

brentvatne May 24, 2020

tsapeta May 25, 2020

sjchmiela commented May 25, 2020

mczernek commented May 25, 2020 •

edited by sjchmiela

tsapeta commented May 25, 2020 •

edited

[android] Bump compileSdkVersion to 29 #8450

[android] Bump compileSdkVersion to 29 #8450

Conversation

tsapeta commented May 22, 2020 • edited

Why

How

Test Plan

ExpoBot commented May 22, 2020 • edited

📋 Missing Changelog

🛠 Suggested fixes:

Apply suggested changes:

github-actions bot commented May 24, 2020

brentvatne May 24, 2020

Choose a reason for hiding this comment

tsapeta May 25, 2020

Choose a reason for hiding this comment

sjchmiela commented May 25, 2020

mczernek commented May 25, 2020 • edited by sjchmiela

tsapeta commented May 25, 2020 • edited

tsapeta commented May 22, 2020 •

edited

ExpoBot commented May 22, 2020 •

edited

mczernek commented May 25, 2020 •

edited by sjchmiela

tsapeta commented May 25, 2020 •

edited