Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert bare-expo to swift #8529

Merged
merged 4 commits into from May 28, 2020
Merged

Convert bare-expo to swift #8529

merged 4 commits into from May 28, 2020

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented May 28, 2020 •
edited

Why

Good for testing this #8526

Test Plan

  • Build bare-expo onto a simulator or device, test that shake gesture works.

@EvanBacon EvanBacon requested a review from sjchmiela May 28, 2020 00:38
@EvanBacon EvanBacon self-assigned this May 28, 2020
sjchmiela
sjchmiela reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making it easy to test Swift support in Expo! 👍

apps/bare-expo/ios/BareExpo.xcodeproj/project.pbxproj Show resolved Hide resolved
apps/bare-expo/ios/BareExpo/AppDelegate.swift Show resolved Hide resolved
apps/bare-expo/ios/BareExpo/AppDelegate.swift Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@EvanBacon EvanBacon marked this pull request as ready for review May 28, 2020 21:18
@EvanBacon EvanBacon merged commit f10bc8a into master May 28, 2020
@EvanBacon EvanBacon deleted the @evanbacon/bare-expo/convert-to-swift branch May 28, 2020 22:30
@tsapeta tsapeta mentioned this pull request Jun 30, 2020
Merged
tsapeta added a commit that referenced this pull request Jul 2, 2020
@tsapeta
[ios] Migrate AppDelegate to Swift 🎉 (#9045)
56962d2 
# Why

Inspired by my God of Swift: #8529 
Also I'm using Swift in `expo-dev-menu`, so converting to AppDelegate seems like a good idea to start using Swift in the client.

# How

- Converted `EXAppDelegate.{h,m}` into `AppDelegate.swift`
- Removed `main.m` (`@UIApplicatonMain` does it)
- Set `DEBUG` and `RELEASE` flags for compatibility

# Test Plan

Simulator build seems to work as great as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjchmiela sjchmiela sjchmiela left review comments

Assignees

@EvanBacon EvanBacon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EvanBacon @sjchmiela