[expo-permissions] show correct lib to link if found unrecognized permission #8546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarvisluong
commented
May 28, 2020
tsapeta
reviewed
May 29, 2020
| @@ -6,6 +6,8 @@ | |||
|
|
|||
| ### 🎉 New features | |||
|
|
|||
| - If permission is not recognized, show the correct expo package to link. ([#8546])(https://github.com/expo/expo/pull/8046) by [@jarvisluong](https://github.com/jarvisluong) | |||
There was a problem hiding this comment.
Looks like you have outdated changelog on your branch 🤔 Those bug fixes below have already been published in 8.2.0
There was a problem hiding this comment.
That's right, my master is 35 commits behind the current master, should I rebase now?
There was a problem hiding this comment.
Yeah I think so, sorry for that 🙂 Unfortunately you may get some issues with rebasing because one of the commit you didn't have is e166a8d which replaced react-native-unimodules as a submodule — we've moved it into the monorepo. Git sometimes has some troubles to resolve such changes right 😞
There was a problem hiding this comment.
this should be fine now 😅
Co-authored-by: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #8466, this PR address the solution.
Test plan:
Expected:
Warning should mention the missing library