[jest-expo] Disable unsupported mjs file extensions #8839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
byCedric
force-pushed
the
@bycedric/jest-expo/disable-mjs
branch
from
c88ddbd
to
b4c6666
Compare
|
cc @EvanBacon |
|
Hmm, ok. I don't think there is a correct way to do mjs right now anyways. |
tsapeta
pushed a commit
that referenced
this pull request
Jun 28, 2020
* [jest-expo] Disable unsupported mjs file extensions * [jest-expo] Only disable mjs and enable typescript and react
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This fixes #8809
.mjsisn't (fully) supported yet bybabel-jest, see this comment and issue.How
It passes the
isModern: falseflag to@expo/config. This should disable all.mjsfile extensions from Jest. Once they fully support this, we can updatebabel-preset-expoandjest-expo.Test Plan
I can add a test, but because this is a temporary measure I'm not sure if this should be added.