[jest-expo] fix jest-preset mutating react-native preset #9051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-fournier
force-pushed
the
fix-jest-tests
branch
from
533b638
to
a4b19f8
Compare
renanmav
approved these changes
Aug 4, 2020
brentvatne
reviewed
Aug 14, 2020
brentvatne
reviewed
Aug 14, 2020
|
Shall we merge? |
|
Any update on this? |
|
cc @brentvatne |
|
Any news? |
|
thanks, this will go out with sdk-40 |
brentvatne
pushed a commit
that referenced
this pull request
Dec 3, 2020
byCedric
pushed a commit
that referenced
this pull request
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #9050
Due to a change in jest-config since v25.0.0, the jest-preset.js file is called twice.
The current implement of expo's jest-preset is based on mutating react-native's jest-preset.
The problem is that now, this file is called twice so the mutation is applied twice, leading to warnings in console and a corrupted jest-preset in output.
How
With a
cloneDeep, the origin preset is no longer mutated and the output is now deterministic.