[expo-av] Fix fullscreen events not emitted on iOS #9323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
bbarthec
approved these changes
Jul 21, 2020
| @@ -52,7 +52,9 @@ export default class VideoPlayer extends React.Component< | |||
|
|
|||
| _handleVideoMount = (ref: Video) => (this._video = ref); | |||
|
|
|||
| _updateStateToStatus = (status: any) => this.setState(status); | |||
| _handlePlaybackStatusUpdate = (status: any) => this.setState(status); | |||
There was a problem hiding this comment.
Suggested change
| _handlePlaybackStatusUpdate = (status: any) => this.setState(status); | |
| _handlePlaybackStatusUpdate = (status: SomeMeaningfulType) => this.setState(status); |
Maybe it would help understanding what state parameters are actually changing? 🤔
There was a problem hiding this comment.
Yeah I agree. I'll have at improving the example in a separate PR 👍
There was a problem hiding this comment.
NLC update PR #9335
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
* [ncl] Log full-screen events * [expo-av] Fix fullscreen events not emitted on iOS * [expo-av] Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #8393. When using the native full-screen controls on iOS, the full-screen events are not (always) emitted.
How
As of iOS 12, full-screen detection can be achieved using the
AVPlayerViewControllerDelegatedelegate.AVPlayerViewControllerDelegatemethods for detecting the full-screen mode changeTest Plan
presentFullScreen..