[media-library] add options for getAssetInfoAsync #9405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry @tsapeta @lukmccall, this PR has been left open for quite sometimes 😅 , I wasn't been able to find time until now. |
lukmccall
requested changes
Jul 27, 2020
packages/expo-media-library/ios/EXMediaLibrary/EXMediaLibrary.m
Outdated
Show resolved
Hide resolved
Done |
lukmccall
reviewed
Jul 27, 2020
lukmccall
approved these changes
Jul 27, 2020
There is still one thing left which is the bare-expo app. I wonder how should we update the demo screen for this API to reflect the possibility of changing the options? Right now, the screen just call |
tsapeta
reviewed
Jul 28, 2020
Co-authored-by: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com>
tsapeta
approved these changes
Jul 29, 2020
Done 👍 |
lukmccall
requested changes
Jul 29, 2020
packages/expo-media-library/ios/EXMediaLibrary/EXMediaLibrary.m
Outdated
Show resolved
Hide resolved
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@student.uj.edu.pl>
lukmccall
approved these changes
Jul 29, 2020
|
@jarvisluong I've just published |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This is an enhanced PR from #8800
How
I added
optionsas the optional second parameter toMediaLibrary.getAssetInfoAsync.Test Plan
Currently I modified
MediaDetailsScreenin bare-expo app with payload ofshouldDownloadFromNetworktofalseso that the response payload also contains the fieldisNetworkAsset.Open question
Since this changes the public API of
MediaLibrary, I wonder how should I update the bare-expo app to reflect this option?