Skip to content

Commit

Permalink
[eas-shared] Prevent qemu emualtor console window from showing up on …
Browse files Browse the repository at this point in the history
…Windows (#192)

* [menu-bar][electron] Implement MenuBar runCli status update

* Add changelog entry

* [eas-shared] Prevent qemu emualtor console window from showing up on Windows

* [menu-bar] Fix progress indicator margins on web
  • Loading branch information
gabrieldonadel committed Mar 12, 2024
1 parent a58f7a6 commit d72021c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Expand Up @@ -15,6 +15,8 @@ export default function ProgressIndicatorView({
style={{
width: 'auto',
height: 6,
marginTop: 8,
marginBottom: 8,
}}
/>
);
Expand Down
3 changes: 2 additions & 1 deletion packages/eas-shared/src/run/android/emulator.ts
Expand Up @@ -97,7 +97,8 @@ export async function bootEmulatorAsync(
// Start a process to open an emulator
const emulatorProcess = spawnAsync(emulatorExecutable, spawnArgs, {
stdio: 'ignore',
detached: true,
// Running detached on Windows causes a CMD window to popup. windowsHide:true does not work. Check https://github.com/nodejs/node/issues/21825
detached: process.platform != 'win32',
});

// we don't want to wait for the emulator process to exit before we can finish `eas build:run` command
Expand Down

0 comments on commit d72021c

Please sign in to comment.