Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Warn user when trying to an iOS app in a incompatible device #194

Merged
merged 4 commits into from Mar 15, 2024

Conversation

gabrieldonadel
Copy link
Member

Why

A lot of times users try to install their device builds on simulators and simulator builds on devices via Orbit. Doing so will throw the following error, which is not really descriptive and leads to some confusion

image

How

Update InstallAndLaunchApp command to check if the type of app is compatible with the selected device before a trying to install it

Test Plan

Screen.Recording.2024-03-14.at.18.53.45.mov

apps/cli/src/commands/InstallAndLaunchApp.ts Outdated Show resolved Hide resolved
apps/cli/src/commands/InstallAndLaunchApp.ts Outdated Show resolved Hide resolved
gabrieldonadel and others added 2 commits March 15, 2024 01:57
Co-authored-by: Brent Vatne <brentvatne@gmail.com>
@gabrieldonadel gabrieldonadel merged commit e7ad094 into main Mar 15, 2024
1 check passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/incompatible-builds branch March 15, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants