Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @types/express as optional peerDependency #96

Merged
merged 1 commit into from Jun 17, 2020
Merged

add @types/express as optional peerDependency #96

merged 1 commit into from Jun 17, 2020

Conversation

brokenmass
Copy link
Contributor

Closes #66

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2020

🦋 Changeset is good to go

Latest commit: 04a9dc3

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mormahr
Copy link
Member

mormahr commented Jun 17, 2020

Hey, we're using changesets to manage the changelog.

Please run yarn chageset, select patch and enter the change description. Something like "Fix TypeScript dependencies for yarn v2 users, by including @types/express as an optional dependency" will do ☺️.


Did you look into optionalDependency? Whats the difference to peerDependenciesMeta?

Thanks for contributing!

@brokenmass
Copy link
Contributor Author

brokenmass commented Jun 17, 2020

there isn't a real difference between optionalDependency and peerDependenciesMeta [].optional (see here : npm/cli#224) and all package manager supports both. peerDependenciesMeta[].optional looks cleaner and is going to be a safer long term standard.

@mormahr : pr updated.

Thanks for you library, I'm glad to contribute back a tiny bit !

@mormahr
Copy link
Member

mormahr commented Jun 17, 2020

Perfect, thanks for sqashing the commits!

@mormahr mormahr merged commit c59b5eb into express-promise-router:trunk Jun 17, 2020
@brokenmass
Copy link
Contributor Author

@mormahr : would you be so kind to trigger a release ?

@brokenmass brokenmass deleted the express-type-optional-peerdependency branch June 18, 2020 08:30
@mormahr
Copy link
Member

mormahr commented Jun 18, 2020

Yes, of course. Been busy yesterday. 😂

@mormahr
Copy link
Member

mormahr commented Jun 19, 2020

@brokenmass Available as v4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@types/express should be a dependency
3 participants