Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support Node.js@22 in the CI #5627

Merged
merged 1 commit into from May 4, 2024

Conversation

mertcanaltin
Copy link
Member

Adds Node.js@22 support to CI

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @mertcanaltin! Maybe there is an error with Node@22... did the tests pass in local?

@mertcanaltin
Copy link
Member Author

Thanks for doing this @mertcanaltin! Maybe there is an error with Node@22... did the tests pass in local?

I got this error when I was node 22 in my local

Copy link
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure in 22 is expected, it fails in 21 as well, but because the existing CI locks to specific versions, it passes in that specific versino of 21.

See nodejs/node#51562 upstream, and #5615 internally

In the CI I am working on in #5599, Im not locking to specific Node versions and instead using latest for a given major, which I prefer and makes these kinds of failures more obvious.

Opened a PR to skip this test in the meantime: #5628

Copy link

@rxmarbles rxmarbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the ability to approve but LGTM as well

@jonchurch jonchurch changed the base branch from master to 4.x May 4, 2024 21:14
@jonchurch jonchurch changed the base branch from 4.x to master May 4, 2024 21:14
@jonchurch
Copy link
Member

This should pass 22 ci after #5628 merged

Might need a rebase or something?

@jonchurch
Copy link
Member

jonchurch commented May 4, 2024

This is good to go now after fixing 22 CI w/ #5628 and #5639

thrash was to get CI to rerun, then rebased after the two fixes

@jonchurch jonchurch merged commit 4b9cd2f into expressjs:master May 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants