Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support other package managers -- add tests for pnpm #130

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

Cubid
Copy link

@Cubid Cubid commented Feb 20, 2024

I am adding some tests on pnpm.
And also a refactoring to centralise some of the commands.

But I am not sure they will run with Github Actions.

@Cubid Cubid force-pushed the feat/other-package-managers branch 3 times, most recently from f569319 to 15a0ea4 Compare February 20, 2024 17:02
@Cubid Cubid force-pushed the feat/other-package-managers branch from 15a0ea4 to a0a4643 Compare February 20, 2024 17:17
@ext
Copy link
Owner

ext commented Feb 21, 2024

Is Lerna v5 an issue? Perhaps it would be better to drop support for it instead?

@Cubid
Copy link
Author

Cubid commented Feb 22, 2024

Is Lerna v5 an issue? Perhaps it would be better to drop support for it instead?

It does not support workspace: URL type for package. I think it is just a combination, so I don't think it is really an issue.
lerna/lerna#2564

@Cubid
Copy link
Author

Cubid commented Mar 1, 2024

@ext Can we merge this?

@ext
Copy link
Owner

ext commented Mar 2, 2024

@ext Can we merge this?

Ah, yes sorry forgot to merge this one

@ext ext merged commit 1431dbb into ext:master Mar 2, 2024
8 checks passed
@Cubid
Copy link
Author

Cubid commented Mar 2, 2024

@ext Can we merge this?

Ah, yes sorry forgot to merge this one

No problem
Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants