New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add : to signoff trailer #2197
add : to signoff trailer #2197
Conversation
Thanks for the opportunity, @extrawurst! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@semioticrobotic Thanks for adding that. This totally slipped my eye. I originally added it, as I need it for the projects I am working on. Nobody complained so far ;) |
Oops! Sorry, @matthiasbeyer, for that ping. 👆 I accidentally hit the "re-request review" button. 😅 I've not made any changes to the patch. And thanks, @domtac, for your kind words! I'm delighted to be able to add this (and my organization's linter sure will love me for it). |
@semioticrobotic thanks for tackling this. can you please see the PR checklist and at the very least provide a changelog entry that matches the projects style and at best also a unittest that calls |
Sure thing, @extrawurst. I'm not a software developer, so don't really know how to run unittests or anything of the sort (maybe @domtac can help?). But I can gladly add an item to the changelog. (Update: Apologies, as I see actually @matthiasbeyer has been added as requested reviewer. Thanks!) |
This pull request addresses #2196.
It adds a
:
character to the signoff trailer by default. This character is necessary for complying with the Conventional Commits standard.I am not a software developer, and unfortunately I do not know how to perform further actions (such as running local tests, etc.). So I will need to request help from someone more knowledgable.