Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add : to signoff trailer #2197

Merged
merged 3 commits into from May 16, 2024
Merged

Conversation

semioticrobotic
Copy link
Contributor

@semioticrobotic semioticrobotic commented Apr 18, 2024

This pull request addresses #2196.

It adds a : character to the signoff trailer by default. This character is necessary for complying with the Conventional Commits standard.

I am not a software developer, and unfortunately I do not know how to perform further actions (such as running local tests, etc.). So I will need to request help from someone more knowledgable.

@semioticrobotic
Copy link
Contributor Author

Thanks for the opportunity, @extrawurst!

Copy link

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@domtac
Copy link
Contributor

domtac commented Apr 18, 2024

@semioticrobotic Thanks for adding that. This totally slipped my eye. I originally added it, as I need it for the projects I am working on. Nobody complained so far ;)
But thanks to you it will soon be compliant. Thanks

@semioticrobotic
Copy link
Contributor Author

semioticrobotic commented Apr 18, 2024

Oops! Sorry, @matthiasbeyer, for that ping. 👆 I accidentally hit the "re-request review" button. 😅 I've not made any changes to the patch.

And thanks, @domtac, for your kind words! I'm delighted to be able to add this (and my organization's linter sure will love me for it).

@extrawurst
Copy link
Owner

@semioticrobotic thanks for tackling this. can you please see the PR checklist and at the very least provide a changelog entry that matches the projects style and at best also a unittest that calls add_sign_off ?

@semioticrobotic
Copy link
Contributor Author

semioticrobotic commented Apr 22, 2024

Sure thing, @extrawurst. I'm not a software developer, so don't really know how to run unittests or anything of the sort (maybe @domtac can help?). But I can gladly add an item to the changelog.

(Update: Apologies, as I see actually @matthiasbeyer has been added as requested reviewer. Thanks!)

@extrawurst extrawurst merged commit fa25153 into extrawurst:master May 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants