Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override build date with SOURCE_DATE_EPOCH #2202

Merged
merged 4 commits into from May 16, 2024

Conversation

bmwiedemann
Copy link
Contributor

It changes the following:

  • checks for SOURCE_DATE_EPOCH env and uses it as build_date

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

Allow to override build date with SOURCE_DATE_EPOCH
to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

This patch was done while working on reproducible builds for openSUSE.

CHANGELOG.md Outdated Show resolved Hide resolved
@extrawurst
Copy link
Owner

thanks for the contribution, just a very small nitpick, otherwise good to go

to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

This patch was done while working on reproducible builds for openSUSE.
@bmwiedemann
Copy link
Contributor Author

Are more changes needed?

@extrawurst
Copy link
Owner

Can you fix the CI issues?

@extrawurst
Copy link
Owner

@bmwiedemann it really is nothing more than running cargo fmt so that it formats the build.rs file you editted

@extrawurst extrawurst added this to the v0.26.2 milestone May 16, 2024
@extrawurst extrawurst merged commit f568445 into extrawurst:master May 16, 2024
18 checks passed
@extrawurst
Copy link
Owner

@bmwiedemann did these changes and merged it, thanks for your contribution

@bmwiedemann bmwiedemann deleted the date branch May 16, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants