Proper tick position for right positioned axis (chartjs#5401)

* Proper tick position for right positioned axis * Test for tick mark drawing
exwm · Apr 11, 2018 · 06a06b1 · 06a06b1
1 parent 21a0108
commit 06a06b1
Show file tree

Hide file tree

Showing 3 changed files with 81 additions and 2 deletions.
diff --git a/src/core/core.scale.js b/src/core/core.scale.js
@@ -705,8 +705,8 @@ module.exports = Element.extend({
 		var itemsToDraw = [];
 
 		var axisWidth = me.options.gridLines.lineWidth;
-		var xTickStart = options.position === 'right' ? me.right : me.right - axisWidth - tl;
-		var xTickEnd = options.position === 'right' ? me.right + tl : me.right;
+		var xTickStart = options.position === 'right' ? me.left : me.right - axisWidth - tl;
+		var xTickEnd = options.position === 'right' ? me.left + tl : me.right;
 		var yTickStart = options.position === 'bottom' ? me.top + axisWidth : me.bottom - tl - axisWidth;
 		var yTickEnd = options.position === 'bottom' ? me.top + axisWidth + tl : me.bottom + axisWidth;
 

diff --git a/test/fixtures/core.scale/tick-drawing.json b/test/fixtures/core.scale/tick-drawing.json
@@ -0,0 +1,79 @@
+{
+    "config": {
+        "type": "horizontalBar",
+        "data": {
+            "labels": ["January", "February", "March", "April", "May", "June", "July"],
+			"datasets": []
+        },
+        "options": {
+            "legend": false,
+            "title": false,
+            "scales": {
+                "xAxes": [{
+                    "type": "category",
+                    "position": "top",
+                    "id": "x-axis-1",
+                    "ticks": {
+                        "display": false
+                    },
+                    "gridLines":{
+                        "drawOnChartArea": false,
+                        "drawBorder": false,
+                        "color": "rgba(0, 0, 0, 1)",
+                        "zeroLineColor": "rgba(0, 0, 0, 1)"
+                    }
+                }, {
+                    "type": "category",
+                    "position": "bottom",
+                    "id": "x-axis-2",
+                    "ticks": {
+                        "display": false
+                    },
+                    "gridLines":{
+                        "drawOnChartArea": false,
+                        "drawBorder": false,
+                        "color": "rgba(0, 0, 0, 1)",
+                        "zeroLineColor": "rgba(0, 0, 0, 1)"
+                    }
+                }],
+                "yAxes": [{
+                    "position": "left",
+                    "id": "y-axis-1",
+                    "type": "linear",
+                    "ticks": {
+                        "display": false,
+                        "min": -100,
+                        "max": 100
+                    },
+                    "gridLines":{
+                        "drawOnChartArea": false,
+                        "drawBorder": false,
+                        "color": "rgba(0, 0, 0, 1)",
+                        "zeroLineColor": "rgba(0, 0, 0, 1)"
+                    }
+                }, {
+                    "type": "linear",
+                    "id": "y-axis-2",
+                    "position": "right",
+                    "ticks": {
+                        "display": false,
+                        "min": 0,
+                        "max": 50
+                    },
+                    "gridLines":{
+                        "drawOnChartArea": false,
+                        "drawBorder": false,
+                        "color": "rgba(0, 0, 0, 1)",
+                        "zeroLineColor": "rgba(0, 0, 0, 1)"
+                    }
+                }]
+            }
+        }
+    },
+    "options": {
+        "canvas": {
+            "height": 256,
+            "width": 512
+        }
+    }
+}
diff --git a/test/fixtures/core.scale/tick-drawing.png b/test/fixtures/core.scale/tick-drawing.png