Make getHoverColor() return the original value if it is CanvasGradient (

chartjs#5865)
exwm · Nov 28, 2018 · 9014f43 · 9014f43
1 parent 8e35eef
commit 9014f43
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/core/core.helpers.js b/src/core/core.helpers.js
@@ -647,7 +647,7 @@ module.exports = function() {
 
 	helpers.getHoverColor = function(colorValue) {
 		/* global CanvasPattern */
-		return (colorValue instanceof CanvasPattern) ?
+		return (colorValue instanceof CanvasPattern || colorValue instanceof CanvasGradient) ?
 			colorValue :
 			helpers.color(colorValue).saturate(0.5).darken(0.1).rgbString();
 	};

diff --git a/test/specs/core.helpers.tests.js b/test/specs/core.helpers.tests.js
@@ -848,6 +848,13 @@ describe('Core helper tests', function() {
 			};
 		});
 
+		it('should return a CanvasGradient when called with a CanvasGradient', function() {
+			var context = document.createElement('canvas').getContext('2d');
+			var gradient = context.createLinearGradient(0, 1, 2, 3);
+
+			expect(helpers.getHoverColor(gradient) instanceof CanvasGradient).toBe(true);
+		});
+
 		it('should return a modified version of color when called with a color', function() {
 			var originalColorRGB = 'rgb(70, 191, 189)';