Color Setting for Icons #903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
gierens
added
enhancement
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
PThorpe92
previously approved these changes
Mar 22, 2024
MartinFillon
previously approved these changes
Mar 22, 2024
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
MartinFillon
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the discussion https://github.com/orgs/eza-community/discussions/891 the user asks about the ability to make the icon color different from the file name color. I took a peek into the code and actually ended up implementing this functionality.
So this adds the
EZA_COLORSvariableicfor icon which ends up as anOption<Style>in theUiStylewithNoneas default. The logic in theFileName.paintis adjusted to apply the icon style when the value isSomeand otherwise fall back to the usual behavior, namely that the icon color matches the file name color.