feat: make hyperlinks usable inside a WSL environment (support all paths) #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviessm
reviewed
Apr 9, 2024
src/output/file_name.rs
Outdated
| ))); | ||
| let distro_name = std::env::var("WSL_DISTRO_NAME").ok(); | ||
| let path = if let Some(distro_name) = distro_name { | ||
| if !abs_path.starts_with("/mnt/") { |
There was a problem hiding this comment.
Thanks for the PR @opalmay! Could you have a look at the clippy warning on the failing CI check and fix it up? Ideally also run clippy locally to check there aren't any other warnings before amending and force-pushing the branch to get the CI to try again?
In case it's not clear, clippy is complaining that the code says "if not X then Y else Z" when it would be clearer as "if X then Z else Y".
opalmay
force-pushed
the
feat_wsl_hyperlinks
branch
2 times, most recently
from
f50af7a
to
7c46306
Compare
opalmay
force-pushed
the
feat_wsl_hyperlinks
branch
from
7c46306
to
8f09929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #913 ,
This solution supports both types of paths, Linux and Windows mounted.
When a path is under /mnt/{drive_letter}, it constructs the equivalent Windows path. Otherwise, the path is simply prefixed to indicate WSL.