New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change windows-only imports to be windows-only #944
Conversation
This fix looks more correct than individually ignoring the BSDs, thank you for the fix. Out of curiosity, how come this conditional inclusion did not affect linux / macos builds and only BSD builds were having the warning in the first place? |
Thanks for the fix! Could you edit your commit msg to conform to conventional commits? Then we are all set to merge 👍 |
Sure, I hope that one works :-) |
I assume it's because Linux and MacOS builds were using the rust version from Cargo.toml (1.70.0) and only the BSD ports were at 1.77.2 already... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the merge commit a024295. normally, we only update branches with rebase.
Apparently this line is required for the Windows build, but leads to warnings on systems that build the eza port with a port of rust 1.77.2, which at this time seems to be limited to the BSDs. Signed-off-by: Volker Schlecht <47375452+VlkrS@users.noreply.github.com>
Thanks for the contribution! 🎉 |
Apparently this line is required for the Windows build, but leads to warnings on systems that build the eza port with a port of rust 1.77.2, which at this time seems to be limited to the BSDs.
Rather than selectively suppress the warning, I suggest to only include this line where needed.