Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): upgrade object-hash to support async/await syntax #203

Merged
merged 2 commits into from
Feb 11, 2020
Merged

(fix): upgrade object-hash to support async/await syntax #203

merged 2 commits into from
Feb 11, 2020

Commits on Feb 11, 2020

  1. (deps): auto-update outdated package-lock.json 

    - these are just the changes an `npm install` made
- it hadn't been changed since at least v0.25.2
    @agilgur5
    agilgur5 committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    9c265b3 View commit details
    Browse the repository at this point in the history

  2. (fix): upgrade object-hash to support async/await syntax 

    - object-hash v2.0.2 adds/fixes support for async functions
  - object-hash v2 has no breaking changes, just drops testing of
    Node < 6
    - Node 5 was EOL April 2018, and on top of that Node 6
      was EOL April 2019, and Node 8 was EOL December 2019, so this is
      still more tested support than is necessary

- objectHashIgnoreUnknownHack isn't useful for its original purpose to
  workaround this, but is still useful for other types of
  objects/syntaxes that object-hash may not handle yet
  (e.g. async generator functions), so leave the hack in
  - might be good to add a warning though? so that those who used this
    option for async/await can upgrade and remove it (and have a
    stable cache again)
    @agilgur5
    agilgur5 committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    9afc8df View commit details
    Browse the repository at this point in the history