Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't error out while catching a buildStart error #422

Merged
merged 1 commit into from Sep 20, 2022

Commits on Sep 17, 2022

  1. fix: don't error out while catching a buildStart error

    - per in-line comment, if an error occurs during `buildStart` initialization, then the `cache` may not exist yet during `buildDone`
      - since we now use `context.error` instead of `throw` during initialization (from the `options` -> `buildStart` change), `buildEnd` will run during initialization
        - and the `cache` var is initialized in `buildStart` as well, so if an error occurs before then, the `cache` won't exist
          - we should gracefully handle this in all cases, since it's possible that even creating the `cache` could throw an error
    
    - this error was hiding the underlying error, which was problematic for DX as well as bug reports (see my issue follow-up)
    
    - add an integration test for `tsconfig` to make sure this code works
      - while this is similar to the previous `tsconfig` integration tests (that were moved to unit tests), this covers all cases of `buildStart` errors, and is not specific to the different `tsconfig` errors (unlike the unit tests)
      - this test will fail without the source code changes in this commit
    agilgur5 committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    5e41afa View commit details
    Browse the repository at this point in the history