Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase no-errors integration timeout to 20s #425

Merged
merged 1 commit into from Sep 20, 2022

Conversation

agilgur5
Copy link
Collaborator

Summary

Increase the timeout on the no-errors integration test suite

Details

  • this was still occasionally failing on CI at 15s, so bump up a bit
    • c.f. this run, this run, this run, and many more
    • only no-errors was timing out, which makes sense, since it does 3 builds for the first test to test against the cache
      • this potentially could be optimized, but it started getting complicated to do so (including some concurrency issues) - so punting on that for now and just increasing the timeout

Note that these have never timed out on me locally, only in CI 馃し

- this was still occassionally failing on CI at 15s, so bump up a bit
  - c.f. https://github.com/ezolenko/rollup-plugin-typescript2/actions/runs/3075482590/jobs/4968935300, https://github.com/ezolenko/rollup-plugin-typescript2/actions/runs/3038898669/jobs/4893183507, https://github.com/ezolenko/rollup-plugin-typescript2/actions/runs/3038898669/jobs/4893561438, and many more
  - only `no-errors` was timing out, which makes sense, since it does 3 builds for the first test to test against the cache
    - this potentially could be optimized, but it started getting complicated to do so (including some concurrency issues)
      - so punting on that for now and just increasing the timeout
@agilgur5 agilgur5 added kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: tests Tests could be improved. Or changes that only affect tests labels Sep 18, 2022
@ezolenko ezolenko merged commit a1ae42b into ezolenko:master Sep 20, 2022
@agilgur5 agilgur5 deleted the test-increase-no-errors-timeout branch July 2, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: tests Tests could be improved. Or changes that only affect tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants