Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switching from tslint (deprecated) to eslint #463

Merged
merged 5 commits into from Sep 26, 2023
Merged

switching from tslint (deprecated) to eslint #463

merged 5 commits into from Sep 26, 2023

Conversation

ezolenko
Copy link
Owner

Summary

tslint is deprecated and now started to produce errors with new typescript

Details

Switching to typescript-eslint

agilgur5
agilgur5 reviewed Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick glance through as I happened to already be on GH and got a notification

package.json Outdated Show resolved Hide resolved
.eslintrc.cjs Outdated Show resolved Hide resolved
.eslintrc.cjs Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@agilgur5 agilgur5 added the scope: dependencies Issues or PRs about updating a dependency label Sep 26, 2023
ezolenko and others added 3 commits September 25, 2023 23:43
@ezolenko @agilgur5
Update package.json
6f0146d 
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
@ezolenko
- updates for review
6a464e8
@ezolenko
- reverting find-cache-dir because it breaks tsjest
2a7e5b3
agilgur5
agilgur5 reviewed Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like CI is passing now -- a few formatting things + a comment, otherwise LGTM

rollup.config.base.js Outdated Show resolved Hide resolved
.eslintrc.cjs Outdated Show resolved Hide resolved
.eslintrc.cjs Outdated Show resolved Hide resolved
.eslintrc.cjs Show resolved Hide resolved
@ezolenko @agilgur5
Apply suggestions from code review
80fc556 
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
agilgur5
agilgur5 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this!

@agilgur5 agilgur5 added the kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs label Sep 26, 2023
@ezolenko ezolenko merged commit 592ed5c into master Sep 26, 2023
6 checks passed
@agilgur5 agilgur5 deleted the eslint branch September 26, 2023 16:20
@agilgur5 agilgur5 mentioned this pull request Nov 7, 2023
Merged
@agilgur5 agilgur5 mentioned this pull request Jan 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 approved these changes

Assignees
No one assigned
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: dependencies Issues or PRs about updating a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ezolenko @agilgur5