Feat various cleanup #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this offers better flow for writing tests and nested describes changing the test setup.
This is derived from PR f#55
f
reviewed
Aug 20, 2022
| @@ -191,8 +203,7 @@ | |||
| * {a: {b: {c: 1, d: 2}}}, "a.b.c" => 1 | |||
| */ | |||
| GraphQLClient.prototype.fragmentPath = function (fragments, path) { | |||
| var getter = new Function("fragments", "return fragments." + path.replace(/\./g, FRAGMENT_SEPERATOR)) | |||
| var obj = getter(fragments) | |||
| var obj = fragments[path.replace(/\./g, FRAGMENT_SEPERATOR)] | |||
There was a problem hiding this comment.
Because it's equivalent, safer, and mentioned in #49
|
@f I removed the "content-length" commit from this PR, as apparently that is a forbidden header by the XMLHttpRequest, so there is no point in manually setting it, the browser should be doing that work for us. |
urkle
force-pushed
the
feat-various-cleanup
branch
from
cd8f63a
to
31f6fac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This performs a few small pieces of cleanup and fixes.
This PR include the changes from
#22
#49
#55
And obviates #64 (update of packages no longer includes this minimist)
Also now that there is jest test rig this PR ensures tests were added for all the above (or tests passing in the case of #49)