issue #138: fix compilation error when using injection within an inne… #139
Conversation
|
@Luolc let's move the discussion related to your PR here ! Yes we need the PR to be green. It's not about sorting the test methods (as tests methods should be orthogonal = independent from each other). Here it's not the issue, or it's not phrased correctly: yes, you must swap gotoTest and gotoTestOne. If the order of these methods is random, ideally your PR should impose an order on the generated methods (but that could be a different issue). |
|
@stephanenicolas Get! I will try to fix the orders problem :) Thx for help! |
|
Np, and feel free to pressure us a bit to review the PR, we don't actively work on Dart 2 as if perfectly fits our need and we are quite busy with Toothpick, our new lib (and our other job tasks accessorily ;) ). |
|
@stephanenicolas hah I will mention you once I update the PR. Good luck for your new task :) |
…n an inner class
|
@stephanenicolas green now :D plz have a check :) |
|
The PR is targeting an older version of Dart. @Luolc can you reproduce the issue you are trying to solve with the version 3.0.1? |
…r class
I have read the CI test and the diff is just the order of generated methods in Henson class.