Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added route tag #19

Closed

Conversation

tburschka
Copy link

This pr will add support for the "@route" tag. This could be useful in environments, where the log is parsed and grouped by the route (e.g. Grafana).

@faabiosr faabiosr self-requested a review April 26, 2023 13:34
@faabiosr
Copy link
Owner

Hi! Thanks for the contribution.

I wondering if the logRoute method has the same data of logPath, could you please create a test or improve them for this case?

@faabiosr
Copy link
Owner

Looks great!
Just one small adjustment, inside of each logger will you see the docs of adding fields, could you please update this part by adding the route?

And the last one, I promise 😊, just squash all commits please.

@tburschka
Copy link
Author

Does github not having a squash featurue during merge by the owner?

@tburschka
Copy link
Author

I'm a little bit confused, hope i did the squash right, if not i can create a new mr with a single commit

@faabiosr
Copy link
Owner

Still showing 5 commits, and unfortunately this repo does not have the squash feature enabled.

@tburschka
Copy link
Author

I made a new one.... #20

@tburschka tburschka closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants