fix #206 : add ipv6 validation method #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariskemper
changed the title
|
@fabian-hiller what do you think about PR, will you merge it, you have any questions or should i add the docs to the same PR? |
|
I plan to review it on the weekend |
|
I want to let you know that I have rescheduled the review for next week. |
fabian-hiller
force-pushed
the
main
branch
7 times, most recently
from
b997a0f
to
6d0cde4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fabian-hiller this is potential fix for #206, i added additional ipv6 validation method.