Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: size > 0 check to isEmpty method and rename configuration field #1782

Merged
merged 1 commit into from
May 18, 2024
Merged

Update: size > 0 check to isEmpty method and rename configuration field #1782

merged 1 commit into from
May 18, 2024

Conversation

alpha951
Copy link
Contributor

@alpha951 alpha951 commented Apr 14, 2024 •
edited by rohanKanojia

Fix #1779

What's changed ?

Inside DockerComposeServiceWrapper.java made below changes addrssing issue #1779

  • size() > 0 check is replaced by isEmpty()
  • Rename configuration field so that it doesn't collide with class level field

@alpha951
Update to isEmpty method and rename configuration field
8607a7d 
Signed-off-by: Keshav Carpenter <keshav950personal@gmail.com>
@alpha951 alpha951 mentioned this pull request Apr 14, 2024
Closed
2 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alpha951
Copy link
Contributor Author

Hey @rahul-kulkarni73, e2e tests for MacOS are failing. Could you please check this.

@alpha951 alpha951 mentioned this pull request Apr 15, 2024
Open
2 tasks
@rohanKanojia rohanKanojia merged commit d23c92c into fabric8io:master May 18, 2024
14 of 18 checks passed
@alpha951 alpha951 deleted the update-isEmpty-check branch May 24, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DockerComposeServiceWrapper : Use isEmpty() to check collection is empty
2 participants
@alpha951 @rohanKanojia