Support platform in external docker-compose config #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StasShymov
force-pushed
the
support-platform-in-external-docker-compose-config
branch
from
db516e4
to
bd6e3f2
Compare
rohanKanojia
approved these changes
May 15, 2024
|
@StasShymov Thanks! Could you please add a line to doc/changelog.md regarding this change? |
StasShymov
force-pushed
the
support-platform-in-external-docker-compose-config
branch
2 times, most recently
from
ca93bf9
to
ced719f
Compare
|
@StasShymov : Could you please address minor sonar code smells? Looks good to be merged. |
Signed-off-by: Stanislav Shymov <stas.shimov@gmail.com>
StasShymov
force-pushed
the
support-platform-in-external-docker-compose-config
branch
from
ced719f
to
52e5266
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac M1 docker-maven-plugin when using external docker-compose.yml configuration produces the following error:
The solution is to add platform declaration to each service image:
which overrides the native platform value
linux/arm64used by default. Unfortunately, theplatformfield in docker-compose config was ignored. This PR fixes that.PS: Virtualization on Mac allows running amd64 build images.