feature(resource): Remove runtimeMode from fabric8:resource #1576
Conversation
Also bumped up snapshot version to 4.1-SNAPSHOT
| @@ -42,11 +42,17 @@ | |||
| } | |||
|
|
|||
| public DeploymentConfig getDeploymentConfig(ResourceConfig config, | |||
| List<ImageConfiguration> images, Long openshiftDeployTimeoutSeconds, Boolean imageChangeTrigger, Boolean enableAutomaticTrigger, Boolean isOpenshiftBuildStrategy) { | |||
| List<ImageConfiguration> images, Long openshiftDeployTimeoutSeconds, Boolean imageChangeTrigger, Boolean enableAutomaticTrigger) { | |||
There was a problem hiding this comment.
Could you please remove PlatformMode import also?
| @@ -89,7 +89,7 @@ items: | |||
| valueFrom: | |||
| fieldRef: | |||
| fieldPath: metadata.namespace | |||
| image: fabric8-maven-sample-zero-config:latest | |||
| image: fabric8/fabric8-maven-sample-zero-config:latest | |||
| imagePullPolicy: IfNotPresent | |||
There was a problem hiding this comment.
I don't think this we should do this, Try deploying this project onto openshift, DeploymentConfigs would not get rolled. I also did the same thing and had to revert this change afterwards. In minishift image is pushed as:
[docker@minishift ~]$ docker images | grep spring-boot
172.30.1.1:5000/myproject/fabric8-maven-sample-spring-boot latest bffc2e90d804 4 minutes ago 603 MB
172.30.1.1:5000/myproject/fabric8-maven-sample-spring-boot <none> dbc792415de5 4 minutes ago 603 MB
|
Strange, build seems to be passing on my machine. |
|
@ro14nd can you group all the part of |
Not required now |
Also bumped up snapshot version to 4.1-SNAPSHOT