Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JUnit5 Kubernetes Extension works with Nested tests #5712

Merged

Conversation

manusa
Copy link
Member

@manusa manusa commented Jan 17, 2024

Description

fix: JUnit5 Kubernetes Extension works with Nested tests

Partially addresses #3032 for the kubernetes-junit-jupiter extension.

The kubernetes-server-mock extension still needs to be fixed (maybe after #5632)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa force-pushed the fix/kubernetes-junit5-extension-nested branch from 8f5470a to 1a37bf5 Compare January 17, 2024 10:37
@manusa manusa force-pushed the fix/kubernetes-junit5-extension-nested branch from 1a37bf5 to 1828771 Compare January 17, 2024 11:08
@manusa manusa added this to the 6.11.0 milestone Jan 17, 2024
Copy link

sonarcloud bot commented Jan 17, 2024

@manusa manusa merged commit 24de48f into fabric8io:main Jan 17, 2024
17 of 19 checks passed
@manusa manusa deleted the fix/kubernetes-junit5-extension-nested branch January 17, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants