Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(crd-generator): refactor approval files #5986

Merged
merged 1 commit into from
May 7, 2024

Conversation

manusa
Copy link
Member

@manusa manusa commented May 7, 2024

Description

Part of #5951 / #5948

test(crd-generator): refactor approval files

  • use quoted strings
  • implement custom namer (first step for v2 test)
  • leverage FileApprovalWriter

Relates to:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa self-assigned this May 7, 2024
- use quoted strings
- implement custom namer (first step for v2 test)
- leverage FileApprovalWriter

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa force-pushed the test/crd-generator-quote branch from 57d92f8 to a4b656b Compare May 7, 2024 09:20
@manusa manusa added this to the 6.13.0 milestone May 7, 2024 — with automated-tasks
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@manusa manusa merged commit fa6a3c3 into fabric8io:main May 7, 2024
20 checks passed
@manusa manusa deleted the test/crd-generator-quote branch May 7, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants