Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: LeaderElector::canBecomeLeader for clarity #6005

Merged
merged 1 commit into from
May 15, 2024

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented May 14, 2024

Fixes #5999

Copy link

sonarcloud bot commented May 14, 2024

@rohanKanojia
Copy link
Member

@wind57 : Could you please mark it ready for review?

@wind57 wind57 marked this pull request as ready for review May 14, 2024 09:52
@manusa manusa changed the title fix 5999 refactor: LeaderElector::canBecomeLeader for clarity May 15, 2024
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa added this to the 6.13.0 milestone May 15, 2024 — with automated-tasks
@manusa manusa merged commit a3f154e into fabric8io:main May 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minor simplification in the code of leader election
3 participants