DRAFT: Visual tests in playrigth with a function list #9481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Stats
|
|
#9110 does what you suggest, using a single browser to run all the snapshots. It is very fast. |
ShaMan123
reviewed
Nov 6, 2023
| if (testCase.disabled !== 'node') { | ||
| await test.step(`node - ${testCase.title}`, async () => { | ||
| // we want the browser snapshot of a test to be committed and not the node snapshot | ||
| config.config.updateSnapshots = 'none'; |
There was a problem hiding this comment.
this is wrong because it will override the -u flag passed in argv
Comment on lines
+59
to
+78
| export async function beforeRenderTest( | ||
| cb: ( | ||
| canvas: Canvas | ||
| ) => AsyncReturnValue<{ title: string; boundFunction: () => void }[]>, | ||
| options | ||
| ) { | ||
| const el = document.querySelector<HTMLCanvasElement>('#canvas'); | ||
| const canvas = new Canvas(el, options); | ||
| // cb has to bind the rendering test to the specific canvas and add a clear before the test | ||
| const renderingTests = await cb(canvas); | ||
| renderingTests.forEach((renderTest) => { | ||
| if (renderingTestMap.has(renderTest.title)) { | ||
| throw new Error( | ||
| `test identifiers must be unique: ${renderTest.title} is already defined` | ||
| ); | ||
| } | ||
| renderingTestMap.set(renderTest.title, renderTest.boundFunction); | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
I am not sure I under this.
Do you want to create a new canvas for every test?
Why? What is the gain?
What about simply resizing the canvas before the test and adding a canvas.clear() after the snapshot call?
Seems more straight forward, simpler and faster and can be exposed on the CanvasUtil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is an idea / proposal to have something simpler to setup when doing visual tests.
As the old QUNIT-VISUAL we can just prepare a list of functions with some metadata and have them run in sequence.
Those will run opening a single browser window and a single ci action, deprecating the old qunit-visual that runs on 3 node versions and 2 browsers.
The code is a bit messy and is not integrated ( on purpose ) with our generic pattern for single interactive e2e tests.
Eventually also my before function would be moved away from where i added it and just be specific of this kind of test.
I didn't convert more tests because i wanted to talk about it first.
Also is not urgent.