-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce some calls to setCoords() #9795
Open
asturur
wants to merge
7
commits into
master
Choose a base branch
from
reduce-setcoords-call
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
asturur
commented
Apr 11, 2024
} | ||
const actionPerformed = | ||
!!actionHandler && actionHandler(e, transform, pointer.x, pointer.y); | ||
actionPerformed && target.setCoords(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build Stats
|
FWIW the PR LGTM, these are the safe changes we did at workplace as well |
i just didn't have time to try it, seems safe to me too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original findings from @ShaMan123 from #9550
The method
setViewportTrasnfrom
from StaticCanvas has code that is not useful anymore and the call to setCoords happening in drawControls will happen on every render with an activeObject. Moving the call in 'setActiveObject' and on the action performed will ensure that for the activeObject the controls are in place.If for the developer will need to draw controls of multiple objects will need to ensure that on everyObject setCoords is called by the developer's code.