Cut over from phantomJS to Karma. #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Code coverage report seems unaffected.
Requires node 16.14 and up going forward
Bonkles
added a commit
that referenced
this pull request
Mar 17, 2022
* Merge iD pull request #8764 into RapiD, replacing phantomjs with karma * Further fixes to get unit tests working. * Ditch the karma-remap-istanbul package, as it did not work in RapiD. Code coverage report seems unaffected. * Fix import assertion error now that we're using node 16. * Use import assertions syntax for importing JSON files Requires node 16.14 and up going forward Co-authored-by: Martin Raifer <martin@raifer.tech> Co-authored-by: Bryan Housel <bhousel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based off the work done in openstreetmap/iD#8764 in the iD repo.
Notable changes: Since we're using esm now we had to rename the
karma.config.jstokarma.config.cjs. Also, thekarma-remap-istanbulplugin was not compatible and caused the test to fail as it couldn't generate coverage data correctly, causing karma to hang and an exit code of1instead of 0.This PR also pulls in the config changes we made to get node 16 working with the json import type assertions.
Screenshot of build action test results:
Succesful run from the staging branch based off this PR: https://github.com/facebookincubator/RapiD/actions/runs/1999797869