Skip to content

Commit

Permalink
Fix build (#7662)
Browse files Browse the repository at this point in the history
  • Loading branch information
ianschmitz committed Sep 9, 2019
1 parent 78fb4cf commit 1f46136
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 18 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -19,7 +19,7 @@
"compile:lockfile": "node tasks/compile-lockfile.js"
},
"devDependencies": {
"eslint": "6.1.0",
"eslint": "^6.1.0",
"execa": "1.0.0",
"fs-extra": "^7.0.1",
"get-port": "^4.2.0",
Expand Down
14 changes: 7 additions & 7 deletions packages/babel-preset-react-app/package.json
Expand Up @@ -21,19 +21,19 @@
"test.js"
],
"dependencies": {
"@babel/core": "7.5.5",
"@babel/core": "7.6.0",
"@babel/plugin-proposal-class-properties": "7.5.5",
"@babel/plugin-proposal-decorators": "7.4.4",
"@babel/plugin-proposal-decorators": "7.6.0",
"@babel/plugin-proposal-object-rest-spread": "7.5.5",
"@babel/plugin-syntax-dynamic-import": "7.2.0",
"@babel/plugin-transform-destructuring": "7.5.0",
"@babel/plugin-transform-destructuring": "7.6.0",
"@babel/plugin-transform-flow-strip-types": "7.4.4",
"@babel/plugin-transform-react-display-name": "7.2.0",
"@babel/plugin-transform-runtime": "7.5.5",
"@babel/preset-env": "7.5.5",
"@babel/plugin-transform-runtime": "7.6.0",
"@babel/preset-env": "7.6.0",
"@babel/preset-react": "7.0.0",
"@babel/preset-typescript": "7.3.3",
"@babel/runtime": "7.5.5",
"@babel/preset-typescript": "7.6.0",
"@babel/runtime": "7.6.0",
"babel-plugin-dynamic-import-node": "2.3.0",
"babel-plugin-macros": "2.6.1",
"babel-plugin-transform-react-remove-prop-types": "0.4.24"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-error-overlay/flow/env.js
Expand Up @@ -2,7 +2,7 @@ declare module 'anser' {
declare module.exports: any;
}

declare module 'babel-code-frame' {
declare module '@babel/code-frame' {
declare module.exports: any;
}

Expand Down
4 changes: 2 additions & 2 deletions packages/react-error-overlay/package.json
Expand Up @@ -35,9 +35,9 @@
],
"devDependencies": {
"@babel/code-frame": "7.5.5",
"@babel/core": "7.5.5",
"@babel/core": "7.6.0",
"anser": "1.4.8",
"babel-eslint": "10.0.2",
"babel-eslint": "10.0.3",

This comment has been minimized.

Copy link
@salomvary

salomvary Sep 9, 2019

It would be amazing to release this change as babel-eslint 10.0.2 is broken which means linting via latest create-react app is broken too: babel/babel-eslint#791

This comment has been minimized.

Copy link
@georgesofianosgr

georgesofianosgr Sep 12, 2019

I'm looking forward to this change too. We see a lot of no_unused_vars warnings because of this.

"babel-jest": "^24.8.0",
"babel-loader": "8.0.6",
"babel-preset-react-app": "^9.0.1",
Expand Down
1 change: 0 additions & 1 deletion packages/react-error-overlay/src/index.js
Expand Up @@ -5,7 +5,6 @@
* LICENSE file in the root directory of this source tree.
*/

/* @flow */
import {
listenToRuntimeErrors,
crashWithFrames,
Expand Down
1 change: 0 additions & 1 deletion packages/react-error-overlay/src/listenToRuntimeErrors.js
Expand Up @@ -5,7 +5,6 @@
* LICENSE file in the root directory of this source tree.
*/

/* @flow */
import {
register as registerError,
unregister as unregisterError,
Expand Down
4 changes: 2 additions & 2 deletions packages/react-scripts/package.json
Expand Up @@ -28,11 +28,11 @@
},
"types": "./lib/react-app.d.ts",
"dependencies": {
"@babel/core": "7.5.5",
"@babel/core": "7.6.0",
"@svgr/webpack": "4.3.2",
"@typescript-eslint/eslint-plugin": "1.13.0",
"@typescript-eslint/parser": "1.13.0",
"babel-eslint": "10.0.2",
"babel-eslint": "10.0.3",
"babel-jest": "^24.8.0",
"babel-loader": "8.0.6",
"babel-plugin-named-asset-import": "^0.3.3",
Expand Down
6 changes: 3 additions & 3 deletions tasks/e2e-simple.sh
Expand Up @@ -94,12 +94,12 @@ startLocalRegistry "$root_path"/tasks/verdaccio.yaml
./node_modules/.bin/eslint --max-warnings 0 packages/eslint-config-react-app/
./node_modules/.bin/eslint --max-warnings 0 packages/react-dev-utils/
./node_modules/.bin/eslint --max-warnings 0 packages/react-scripts/
./node_modules/.bin/eslint --max-warnings 0 packages/react-error-overlay/src/

cd packages/react-error-overlay/
./node_modules/.bin/eslint --max-warnings 0 src/
yarn test
if [ $APPVEYOR != 'True' ]; then
# Flow started hanging on AppVeyor after we moved to Yarn Workspaces :-(
if [ $AGENT_OS != 'Windows_NT' ]; then
# Flow started hanging on Windows build agents
yarn flow
fi
cd ../..
Expand Down

0 comments on commit 1f46136

Please sign in to comment.