Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated deprecated rules #11622

Merged
merged 1 commit into from Jan 12, 2022
Merged

updated deprecated rules #11622

merged 1 commit into from Jan 12, 2022

Conversation

wisammechano
Copy link
Contributor

Recent eslint update deprecated rules no-native-reassign & no-negated-in-lhs in favor off no-global-assign & no-unsafe-negation.

I've tested this working by turning off these 2 rules in package.json eslint config, and adding the updated rules instead. It stopped the deprecation warning.

Recent eslint update deprecated rules `no-native-reassign` & `no-negated-in-lhs` in favor off `no-global-assign` & `no-unsafe-negation`.
@facebook-github-bot
Copy link

Hi @wisammechano!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@raix raix added this to the 5.0.1 milestone Dec 18, 2021
@iansu iansu merged commit 63ae6dd into facebook:main Jan 12, 2022
@iansu
Copy link
Contributor

iansu commented Jan 12, 2022

Thanks!

GoetzGoerisch pushed a commit to umati/create-react-app that referenced this pull request Jan 13, 2022
GoetzGoerisch pushed a commit to umati/create-react-app that referenced this pull request Jan 13, 2022
aruniverse pushed a commit to imodeljs/create-react-app that referenced this pull request Sep 6, 2022
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants