Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Origin header on proxied WebSocket requests #12583

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change Origin header on proxied WebSocket requests #12583

wants to merge 2 commits into from

Commits on Apr 3, 2024

  1. Change Origin header on proxied WebSocket requests 

    Similar to CORS controls, WebSocket servers are often (see below)
configured to check the Origin header of incoming requests. The config
for the HTTP proxy overwrites requests' Origin header to prevent issues
with CORS, but didn't previously do the same thing for WebSockets, as
they are controlled by a different config key.

Fixes facebook#10878
    @treuherz
    treuherz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    daf0814 View commit details
    Browse the repository at this point in the history

  2. Ensure proxy heuristic works for WebSocket requests on Chrome

    @treuherz
    treuherz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    a34d066 View commit details
    Browse the repository at this point in the history