brikk #12853
Open
brikk #12853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com> Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com>
The root domain, chaijs.com, does not serve a valid certificate and gives a browser warning.
* Explain how to uninstall create-react-app globally * Add uninstallation intructions for yarn
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> Co-authored-by: Ian Sutherland <ian@iansutherland.ca>
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
…-VS-Code-debugger update a debugger for VS Code
Update making-a-progressive-web-app.md
Update getting-started.md
Update adding-a-router.md
Update links in `README`
Chore: Update document to GitHub default branch
Update URL Co-authored-by: Nurlan Suyundukov <14142638+suyundukov@users.noreply.github.com>
Updated pace.js link
…ist-1.2.6 Bump minimist from 1.2.5 to 1.2.6
…ructions Chore: (Docs) Updates for the Storybook docs
docs: Make hyperlink consistent
docs: update jest links
When adding typescript to an existing Create React App project you have to have tsconfig.json in the project, I believe this change should clarify it for beginners getting stuck on this step. Not sure if providing an example would be too much so I have added a link to the tsconfig.json instead.
Add a link to React Router docs specific to adding routes.
Remove reference to deprecated VSCode debugger plugin. https://marketplace.visualstudio.com/items?itemName=msjsdiag.debugger-for-chrome
fix code splitting link
fix broken link progressive web app
docs: Add Link to Adding Routes Docs
update the heroku buildpack link
Add missing instruction if you are adding typescript
VSCode debugger plugin deprecated
|
yeah |
In #11318 a change was made to `babel-preset-react-app` to require `@babel/plugin-proposal-private-property-in-object`, but no such dependency was added to `package.json`. This fixes that mistake by adding the dependency.
|
Hi @Billydee87! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Beyond just a pure migration, this also: - Drops Node 14 usage from CI (which also removes the need for explicit npm 8 installs) - Removes the "old node" test, which just checked that installing on old node failed. We shouldn't need to test that - Consolidates the build & test workflows so we don't end up with a proliferation of workflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create-react-app-d960b9e38c062584ff6cfb1a70e1512509a966e7.zip