Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin envinfo version to 3.4.2 #3853

Merged
merged 1 commit into from
Jan 18, 2018
Merged

pin envinfo version to 3.4.2 #3853

merged 1 commit into from
Jan 18, 2018

Conversation

bondz
Copy link
Contributor

@bondz bondz commented Jan 18, 2018

See #3837

@bondz
Copy link
Contributor Author

bondz commented Jan 18, 2018

One problem with this is that the --noNativeIDE flag isn't available in this version, so the version of XCode or Android studio on the user's PC would be printed to screen. cc @tabrindle

@gaearon gaearon merged commit 2bf0929 into facebook:master Jan 18, 2018
gaearon pushed a commit that referenced this pull request Jan 18, 2018
@bondz bondz deleted the patch-3 branch January 18, 2018 13:51
akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
vojtechsimetka added a commit to Giveth/create-react-app that referenced this pull request May 28, 2018
* 'master' of https://github.com/facebook/create-react-app: (220 commits)
  Publish
  Changelog for 1.1.4
  Update detect-port-alt (facebook#4250)
  Publish
  Changelog for 1.1.3
  Work around Jest environment resolving bug (facebook#4247)
  Publish
  Add 1.1.2 changelog (facebook#4242)
  Add troubleshooting for Github Pages (facebook#4197)
  `.mjs` should not resolve before .js files (facebook#4085)
  Publish
  Revert "Set the public path to the asset manifest entries (facebook#2544)"
  Add 1.1.1 changelog
  Unpin and bump fsevents (for 1.x branch) (facebook#4006)
  Update dotenv-expand to fix bug with environment variables that contain a $. (facebook#4000)
  Update instructions for continuous delivery with Netlify (facebook#3971)
  Include `{json,css}` files in prettier command (facebook#3894)
  Set the public path to the asset manifest entries (facebook#2544)
  1.5.1
  pin envinfo version to 3.4.2 (facebook#3853)
  ...

# Conflicts:
#	packages/react-scripts/config/webpack.config.prod.js
#	packages/react-scripts/package.json
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants