Include {json,css} files in prettier command
#3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update User Guide's README.md to include `json` and `css` files in the command to format the entire project for the first time with prettier, that it's consistent with the `lint-staged` command.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Zaccc123
pushed a commit
to Zaccc123/create-react-app
that referenced
this pull request
May 21, 2018
Update User Guide's README.md to include `json` and `css` files in the command to format the entire project for the first time with prettier, that it's consistent with the `lint-staged` command.
vojtechsimetka
added a commit
to Giveth/create-react-app
that referenced
this pull request
May 28, 2018
* 'master' of https://github.com/facebook/create-react-app: (220 commits) Publish Changelog for 1.1.4 Update detect-port-alt (facebook#4250) Publish Changelog for 1.1.3 Work around Jest environment resolving bug (facebook#4247) Publish Add 1.1.2 changelog (facebook#4242) Add troubleshooting for Github Pages (facebook#4197) `.mjs` should not resolve before .js files (facebook#4085) Publish Revert "Set the public path to the asset manifest entries (facebook#2544)" Add 1.1.1 changelog Unpin and bump fsevents (for 1.x branch) (facebook#4006) Update dotenv-expand to fix bug with environment variables that contain a $. (facebook#4000) Update instructions for continuous delivery with Netlify (facebook#3971) Include `{json,css}` files in prettier command (facebook#3894) Set the public path to the asset manifest entries (facebook#2544) 1.5.1 pin envinfo version to 3.4.2 (facebook#3853) ... # Conflicts: # packages/react-scripts/config/webpack.config.prod.js # packages/react-scripts/package.json
Pavek
pushed a commit
to Pavek/create-react-app
that referenced
this pull request
Jul 10, 2018
Update User Guide's README.md to include `json` and `css` files in the command to format the entire project for the first time with prettier, that it's consistent with the `lint-staged` command.
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Aug 14, 2018
Update User Guide's README.md to include `json` and `css` files in the command to format the entire project for the first time with prettier, that it's consistent with the `lint-staged` command.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update User Guide's README.md to include
jsonandcssfiles in the command to format the entire project for the first time
with prettier, so that it's consistent with the
lint-stagedcommand.As simple as that, don't think any more explanation is needed. Does it make sense to you guys?
Feel free to edit the PR or commit message if needed.