Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mini-css-extract-plugin warnings #6791

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix mini-css-extract-plugin warnings #6791

wants to merge 3 commits into from

Conversation

pnarielwala
Copy link
Contributor

Hello!

I'm proposing this change to fix Conflicting order between errors coming from mini-css-extract-plugin. It seems like these warnings are pointless when using CSS modules

webpack-contrib/mini-css-extract-plugin#250 (comment)

@pnarielwala
Fix mini-css-extract-plugin warnings
d775f94 
Fix order warnings for CSS modules
@stale
Copy link

stale bot commented May 10, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label May 10, 2019
@bugzpodder bugzpodder removed the stale label May 10, 2019
@bugzpodder bugzpodder added this to In progress in v3.1 via automation May 10, 2019
@bugzpodder
Copy link

#5372
@pnarielwala what does the Draft status mean?

@piyushchauhan2011
Copy link

Hmm, I think everyone is waiting for this PR webpack-contrib/mini-css-extract-plugin#422

@bugzpodder bugzpodder added this to the 3.x milestone Aug 11, 2019
@bugzpodder bugzpodder removed this from In progress in v3.1 Aug 11, 2019
@bugzpodder bugzpodder added this to In progress in v3.3 via automation Aug 11, 2019
@bugzpodder bugzpodder removed this from In progress in v3.3 Aug 11, 2019
@feonit
Copy link

feonit commented Aug 26, 2019

How we can enable that "ignoreOrder" property in CRA?

@TCezarRod
Copy link

That PR has been merged and released in v0.8.0 of mini-css-extract-plugin
Maybe we could use ignoreOrder now? 😄

@sadsa
Copy link

sadsa commented Oct 4, 2019 •
edited

Please can somebody look into this? It's currently breaking our CI build as it's warnings are exiting with an error code

@pnarielwala pnarielwala marked this pull request as ready for review October 21, 2020 22:22
@sammckay10
Copy link

Any news on this? I've been having the issue since slowly moving some components from regular SCSS to SCSS modules. I can make it work with ignoreOrder after ejecting CRA but that's not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugzpodder bugzpodder bugzpodder approved these changes

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pnarielwala @bugzpodder @piyushchauhan2011 @feonit @TCezarRod @sadsa @sammckay10 @facebook-github-bot