Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable no-dupe-class-members rule for TypeScript #6987

Merged
merged 1 commit into from May 7, 2019
Merged

Disable no-dupe-class-members rule for TypeScript #6987

merged 1 commit into from May 7, 2019

Conversation

ianschmitz
Copy link
Contributor

Fixes #6986.

@ianschmitz ianschmitz added this to the 3.0.1 milestone May 5, 2019
@ianschmitz ianschmitz mentioned this pull request May 5, 2019
Closed
@ianschmitz ianschmitz changed the title Disable no-dupe-class-members for TypeScript Disable no-dupe-class-members rule for TypeScript May 5, 2019
petetnt
petetnt approved these changes May 5, 2019
View reviewed changes
Copy link
Contributor

@petetnt petetnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianschmitz ianschmitz closed this May 7, 2019
@ianschmitz ianschmitz reopened this May 7, 2019
@ianschmitz ianschmitz merged commit 6ff2bfa into facebook:master May 7, 2019
@ianschmitz ianschmitz deleted the eslint-ts-errors branch May 7, 2019 16:17
@lock lock bot locked and limited conversation to collaborators May 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iansu iansu iansu approved these changes

@petetnt petetnt petetnt approved these changes

@amyrlam amyrlam Awaiting requested review from amyrlam

@bugzpodder bugzpodder Awaiting requested review from bugzpodder

@gaearon gaearon Awaiting requested review from gaearon

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

Broken eslint rule configuration for typescript with CRA 3.*
4 participants
@ianschmitz @iansu @petetnt @facebook-github-bot