Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: note that 2 to 3 migration may require deletion of node_modules #7302

Merged
merged 2 commits into from Oct 1, 2019

Conversation

kimpers
Copy link
Contributor

@kimpers kimpers commented Jun 30, 2019

I ran into weird issues with calling functions that do not exist when upgrading from 2.1.8 to 3.0.0, the issues were resolved by simply deleting the node_modules folder and doing a full install.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Aug 1, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Aug 1, 2019
@iansu iansu removed the stale label Aug 1, 2019
@iansu iansu self-assigned this Aug 1, 2019
@iansu iansu added this to the 3.1 milestone Aug 1, 2019
@iansu iansu added this to In progress in v3.1 via automation Aug 1, 2019
CHANGELOG.md Outdated Show resolved Hide resolved
@iansu iansu added this to In progress in v3.3 via automation Aug 9, 2019
@iansu iansu removed this from In progress in v3.1 Aug 9, 2019
@iansu iansu modified the milestones: 3.1, 3.2 Aug 9, 2019
Co-Authored-By: Ian Sutherland <ian@iansutherland.ca>
@ianschmitz ianschmitz modified the milestones: 3.2, 3.1.3 Oct 1, 2019
@ianschmitz ianschmitz removed this from In progress in v3.3 Oct 1, 2019
@ianschmitz ianschmitz merged commit 6980616 into facebook:master Oct 1, 2019
@lock lock bot locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants