only load eslint config when EXTEND_ESLINT environment variable is specified/ do not swallow eslint config errors #7530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ru4l
requested review from
bugzpodder,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
This is a good change, thanks. I'll try to take a look next week (I'm on a business trip now) - unless someone else takes a look before then. The performance issue would be very small though, as this only runs one time at start. |
|
Hey, @mrmckeb, it would be awesome if you could review this pull request once you got some time for it! I still think that this is a major pain-point for using a custom eslint config. |
|
@n1ru4l do you mind resolving the conflict? |
|
@ianschmitz done 👍 |
ianschmitz
approved these changes
Sep 16, 2019
|
I believe this fixes #7552 |
mrmckeb
approved these changes
Sep 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the following discussion that got no response:
#7513 (review)
#7513 (comment)
#7510 (comment)
Summary:
Swallowing the eslint config error is not a good idea
The line
eslintConfig = eslintCli.getConfigForFile(paths.appIndexJs);can throw in case the provided eslint config is invalid, e.g. when there is a typo or a plugin dependency is missing. Swallowing that error in case the user explicitly sets theEXTEND_ESLINTenvironment variable (and therefore expects that his eslint config is used) makes debugging such issues unnecessary cumbersome.The eslint config should only be loaded in case the user wants to load it
The eslint config is never used in case the
EXTEND_ESLINTis not set. Therefore it makes sense to only resolve it's path in case the environment variable is set.