Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version of @typescript-eslint/* #7540

Merged
merged 3 commits into from Sep 11, 2019
Merged

Bump version of @typescript-eslint/* #7540

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dec185c
Bump version of @typescript-eslint/*
pierreneter Aug 15, 2019
b8364f6
update
pierreneter Sep 10, 2019
af3db79
Merge branch 'master' into bump-version-of-typescript-eslint
pierreneter Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eslint-config-react-app/README.md
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ If you want to use this ESLint configuration in a project not built with Create
First, install this package, ESLint and the necessary plugins.

```sh
npm install --save-dev eslint-config-react-app @typescript-eslint/eslint-plugin@1.x @typescript-eslint/parser@1.x babel-eslint@10.x eslint@6.x eslint-plugin-flowtype@3.x eslint-plugin-import@2.x eslint-plugin-jsx-a11y@6.x eslint-plugin-react@7.x eslint-plugin-react-hooks@1.x
npm install --save-dev eslint-config-react-app @typescript-eslint/eslint-plugin@2.x @typescript-eslint/parser@2.x babel-eslint@10.x eslint@6.x eslint-plugin-flowtype@3.x eslint-plugin-import@2.x eslint-plugin-jsx-a11y@6.x eslint-plugin-react@7.x eslint-plugin-react-hooks@1.x
```

Then create a file named `.eslintrc.json` with following contents in the root folder of your project:
Expand Down
8 changes: 7 additions & 1 deletion packages/eslint-config-react-app/index.js
View file
Open in desktop
Expand Up @@ -78,7 +78,13 @@ module.exports = {
'no-undef': 'off',

// Add TypeScript specific rules (and turn off ESLint equivalents)
'@typescript-eslint/no-angle-bracket-type-assertion': 'warn',
'@typescript-eslint/consistent-type-assertions': [
pierreneter marked this conversation as resolved.
Show resolved Hide resolved
'warn',
{
assertionStyle: 'as',
objectLiteralTypeAssertions: 'allow',
},
],
'no-array-constructor': 'off',
'@typescript-eslint/no-array-constructor': 'warn',
'@typescript-eslint/no-namespace': 'error',
Expand Down
4 changes: 2 additions & 2 deletions packages/eslint-config-react-app/package.json
View file
Open in desktop
Expand Up @@ -15,8 +15,8 @@
"index.js"
],
"peerDependencies": {
"@typescript-eslint/eslint-plugin": "1.x",
"@typescript-eslint/parser": "1.x",
"@typescript-eslint/eslint-plugin": "2.x",
"@typescript-eslint/parser": "2.x",
"babel-eslint": "10.x",
"eslint": "6.x",
"eslint-plugin-flowtype": "3.x",
Expand Down
4 changes: 2 additions & 2 deletions packages/react-scripts/package.json
View file
Open in desktop
Expand Up @@ -30,8 +30,8 @@
"dependencies": {
"@babel/core": "7.5.5",
"@svgr/webpack": "4.3.2",
"@typescript-eslint/eslint-plugin": "1.13.0",
"@typescript-eslint/parser": "1.13.0",
"@typescript-eslint/eslint-plugin": "2.0.0",
pierreneter marked this conversation as resolved.
Show resolved Hide resolved
"@typescript-eslint/parser": "2.0.0",
"babel-eslint": "10.0.2",
"babel-jest": "^24.8.0",
"babel-loader": "8.0.6",
Expand Down