Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --single-quote from prettier examples #7663

Merged
merged 1 commit into from Sep 11, 2019
Merged

Remove --single-quote from prettier examples #7663

merged 1 commit into from Sep 11, 2019

Conversation

brlewis
Copy link
Contributor

@brlewis brlewis commented Sep 9, 2019

Passing options directly to the cli is not great practice, since default editor integrations won't pick it up and many people are just going to copy paste this snippet. This change removes that customization and prettier will use its very sane defaults.

Closes #7615

Passing options directly to the cli is not great practice, since default editor integrations won't pick it up and many people are just going to copy paste this snippet. This change removes that customization and prettier will use its very sane defaults.

Closes #7615
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@brlewis
Copy link
Contributor Author

brlewis commented Sep 9, 2019

There's no original creative work in this PR. Everything is copied verbatim from #7646 including the commit message. EDIT: I see from the CLA that I'm required to say "Submitted on behalf of a third-party: @heyimalex "

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz added this to the 3.1.2 milestone Sep 11, 2019
@ianschmitz ianschmitz merged commit 74eb65a into facebook:master Sep 11, 2019
@ianschmitz
Copy link
Contributor

Thanks!

@lock lock bot locked and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document prettier integration better
6 participants