Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add babel runtime version to transform-runtime plugin to reduce bundle size #7726

Merged
merged 2 commits into from Oct 6, 2019

Conversation

topaxi
Copy link
Contributor

@topaxi topaxi commented Sep 24, 2019

(Reopening due to force-push #7725)

By default, babel assumes babel/helpers version 7.0.0-beta.0, this PR explicitly resolves the helpers to match the provide functions.

See: babel/babel#10261

Looking at the code in babel-plugin-transform-runtime/src/index.js it does not seem to be enough to provide an absolute path to the runtime.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@d3dc
Copy link

d3dc commented Sep 27, 2019

I can confirm there are several issues with the version of helpers being used. Our bundle size is very bloated thanks to ownKeys and doesn't have some Object.keys polyfills leading to crashes.

All research points to this PR being the fix.

@topaxi topaxi changed the title Add runtime version to transform-runtime plugin Add runtime version to transform-runtime plugin to improve app bundle sizes Oct 4, 2019
@ianschmitz ianschmitz added this to the 3.2.1 milestone Oct 5, 2019
@ianschmitz
Copy link
Contributor

@topaxi have you verified that this change shrinks your bundle size?

@topaxi
Copy link
Contributor Author

topaxi commented Oct 6, 2019

Yes, this reduces the filesize of each of our chunks by about 200 bytes after gzip.

@ianschmitz ianschmitz changed the title Add runtime version to transform-runtime plugin to improve app bundle sizes Add babel runtime version to transform-runtime plugin to reduce bundle size Oct 6, 2019
@ianschmitz ianschmitz merged commit ac93f31 into facebook:master Oct 6, 2019
@ianschmitz
Copy link
Contributor

Thanks @topaxi!

@topaxi topaxi deleted the transform-runtime-version branch October 7, 2019 06:47
@sumanbh
Copy link

sumanbh commented Oct 11, 2019

@topaxi @ianschmitz Is there a reason we're not doing the same when compiling dependencies here? Just curious.

Edit: Nevermind. Looks like @babel/runtime is excluded from dependencies.

@lock lock bot locked and limited conversation to collaborators Oct 16, 2019
@iansu iansu modified the milestones: 3.2.1, 3.3 Oct 23, 2019
@iansu iansu added this to In progress in v3.3 via automation Oct 23, 2019
@iansu iansu moved this from In progress to Done in v3.3 Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
v3.3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants